fix(editor): preserve custom title property through UI edit cycle#1189
Open
perber wants to merge 2 commits into
Open
fix(editor): preserve custom title property through UI edit cycle#1189perber wants to merge 2 commits into
perber wants to merge 2 commits into
Conversation
Pages with `title` + `leafwiki_title` in frontmatter lost the `title` value on every UI save because it was treated as a reserved key. - `HasLeafWikiTitle` flag distinguishes explicit `leafwiki_title` from the alias case - `IsSystemKey()` replaces three diverging local reserved-key maps - `UpsertContentAndMetadata`: new UI-edit path taking structured body/tags/props - `title` removed from frontend property key validation
…operty Removes the HasLeafWikiTitle sentinel flag from Frontmatter and the associated conditional filtering in extractPageMetadata, ExtractPropertiesFromContent, and validatePageMetadataInput. A 'title' key in ExtraFields is now unconditionally a user-defined custom property that round-trips through the editor unchanged.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages with
title+leafwiki_titlein frontmatter lost thetitlevalue on every UI save because it was treated as a reserved key.HasLeafWikiTitleflag distinguishes explicitleafwiki_titlefrom the alias caseIsSystemKey()replaces three diverging local reserved-key mapsUpsertContentAndMetadata: new UI-edit path taking structured body/tags/propstitleremoved from frontend property key validation