Repository navigation
project release: fix 'Added' changelog noise; gate release QA on qa-release label - #202
Merged
Merged
Conversation
In a release project every repository reports "disabled", so the (repo, arch) _fetch_all_pkg_archs picks is just the first listed. For a package built only in some repos (gdal38/proj96 on RockyLinux_8, percona-psql on ssl1.1/ssl3) that repo holds no binaries, the version lookup returned nothing, and the CHANGELOG reported the package as "add upstream version" on every release. Try the package's other repos until one has binaries. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Populate still runs on every release-PR open/push; the QA fan-out runs only when the PR carries the qa-release label. Adding the label later triggers a run that skips populate and runs QA against the existing pre-release; any other label skips the run. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Release versions from any repo with binaries
project releaseread each package's previous-release version from one (repo, arch) of the release project. There every repo isdisabled, so the pick is just the first listed. For packages built only in some repos it has no binaries: gdal38/proj96 (RockyLinux_8 only) and percona-psql (ssl1.1/ssl3) came back versionless, so every release CHANGELOG listed them under Added._fetch_project_pkg_versionsnow tries the package's other repos until one has binaries.Checked against production
isv:percona:ppg:releases:17: gdal383.8.5-2.8.el8, proj969.6.2-1.7.el8, percona-psql17.11-1.36.el8(previously missing). Regression test added; it fails without the fix.2. Gate release QA on the
qa-releaselabelobs-release-pr.yml:qa-releaselabel;Docs, the copilot instructions and the pre-release PR comment are updated.
The
qa-releaselabel must be created in the repo before it can be used.