Skip to content

K8SPG-851 introduce persistent logs#1675

Draft
gkech wants to merge 1 commit into
mainfrom
K8SPG-851
Draft

K8SPG-851 introduce persistent logs#1675
gkech wants to merge 1 commit into
mainfrom
K8SPG-851

Conversation

@gkech

@gkech gkech commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

CHANGE DESCRIPTION

Jira: https://perconadev.atlassian.net/browse/K8SPG-851


Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

Comment on lines +11 to +15
printf '%s %s\n' "$schedule" "$cmd" > /tmp/crontab
exec supercronic /tmp/crontab
else
exec go-cron "$schedule" sh -c "$cmd"
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
printf '%s %s\n' "$schedule" "$cmd" > /tmp/crontab
exec supercronic /tmp/crontab
else
exec go-cron "$schedule" sh -c "$cmd"
fi
printf '%s %s\n' "$schedule" "$cmd" >/tmp/crontab
exec supercronic /tmp/crontab
else
exec go-cron "$schedule" sh -c "$cmd"
fi

rm -rf /tmp/passwd
fi

# Operator-managed postgres.conf overrides the default when present.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
# Operator-managed postgres.conf overrides the default when present.
# Operator-managed postgres.conf overrides the default when present.

"strings"
"time"

"github.com/percona/percona-postgresql-operator/v2/percona/logcollector"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[goimports-reviser] reported by reviewdog 🐶

Suggested change
"github.com/percona/percona-postgresql-operator/v2/percona/logcollector"

@JNKPercona

Copy link
Copy Markdown
Collaborator
Test Name Result Time
backup-enable-disable passed 00:15:13
builtin-extensions passed 00:06:25
cert-manager-tls passed 00:10:02
custom-envs passed 00:18:47
custom-tls passed 00:06:30
database-init-sql passed 00:02:41
demand-backup passed 00:23:59
demand-backup-offline-snapshot passed 00:13:48
dynamic-configuration passed 00:03:27
finalizers passed 00:03:51
init-deploy passed 00:03:55
huge-pages passed 00:02:53
major-upgrade-14-to-15 passed 00:13:21
major-upgrade-15-to-16 passed 00:11:32
major-upgrade-16-to-17 passed 00:16:53
major-upgrade-17-to-18 passed 00:10:24
ldap passed 00:06:02
ldap-tls passed 00:05:40
monitoring passed 00:10:50
monitoring-pmm3 passed 00:13:41
one-pod passed 00:06:39
operator-self-healing passed 00:10:57
pitr passed 00:13:08
scaling passed 00:05:41
scheduled-backup passed 00:29:11
self-healing passed 00:09:54
sidecars passed 00:02:52
standby-pgbackrest passed 00:18:47
standby-streaming passed 00:13:20
start-from-backup passed 00:11:16
tablespaces passed 00:07:05
telemetry-transfer passed 00:04:39
upgrade-consistency passed 00:06:27
upgrade-minor passed 00:06:44
users passed 00:05:20
Summary Value
Tests Run 35/35
Job Duration 01:46:52
Total Test Time 05:52:12

commit: 1ff2f02
image: perconalab/percona-postgresql-operator:PR-1675-1ff2f02d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants