PS [DOCS] - audit log filter updates 8.4#702
Open
patrickbirch wants to merge 4 commits into
Open
Conversation
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 15:50
b8c8d84 to
0236849
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 20:01
0236849 to
54e525f
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 20:04
54e525f to
068ebde
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 20:27
068ebde to
b1e70ea
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 20:55
b1e70ea to
3254689
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 20:55
3254689 to
9678207
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 7, 2026 22:31
9678207 to
d3ddba4
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 8, 2026 09:38
d3ddba4 to
d3a4631
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 8, 2026 11:06
d3a4631 to
9f239ec
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 8, 2026 11:16
9f239ec to
9fc9bc8
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 8, 2026 13:19
9fc9bc8 to
c06bf55
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 15, 2026 13:24
0789e5a to
0f97c19
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 15, 2026 13:36
0f97c19 to
d9d2114
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 15, 2026 13:58
d9d2114 to
3e2e09d
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 15, 2026 14:04
3e2e09d to
71af4d2
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 09:32
71af4d2 to
aeec87e
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 09:45
aeec87e to
30983cc
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 09:58
30983cc to
178300d
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 10:49
178300d to
4695d7b
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 10:57
4695d7b to
dde0c7b
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 11:01
dde0c7b to
9371742
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 11:18
9371742 to
a3ee50a
Compare
patrickbirch
force-pushed
the
ps-audit-update-8.4
branch
from
April 16, 2026 17:22
a3ee50a to
6e072df
Compare
alina-derkach-oaza
approved these changes
May 12, 2026
inikep
suggested changes
Jun 16, 2026
inikep
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the audit_log_filter doc updates against the component source at components/audit_log_filter/ (PS 8.4). The bulk of the changes — system variables, UDFs, filter-definition JSON, formats, encryption/compression, file naming, and migration — verify correctly against the source.
Four factual errors need fixing (inline):
install-audit-log-filter.md—INSTALL COMPONENT 'file://audit_log_filter'is missing thecomponent_prefix; as written it fails to load.block-statements-with-audit-filter.md— "Blocked statements are still logged" is backwards; blocked events go to the server error log, not the audit log.block-statements-with-audit-filter.md— the "Not every event is abortable" section describes a "Can be Aborted" column and an abortability gate that don't exist in the docs or the component.audit-log-filter-old.md— the OLD "Optional attributes" table lists five NEW-format-only elements (MYSQL_VERSION,OS_VERSION,STARTUP_OPTIONS,STATUS_CODE,VERSION).
Details and source citations are in the line comments.
inikep
reviewed
Jun 16, 2026
inikep
reviewed
Jun 16, 2026
inikep
reviewed
Jun 16, 2026
inikep
reviewed
Jun 16, 2026
inikep
left a comment
Collaborator
There was a problem hiding this comment.
Follow-up on the redact-audit-log-fields.md page: one factual correction on the count of replaceable fields (inline). The rest of the page verifies correctly against the component source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/audit-log-filter-formats.md
docs/audit-log-filter-json.md
docs/audit-log-filter-naming.md
docs/audit-log-filter-new.md
docs/audit-log-filter-overview.md
docs/audit-log-filter-restrictions.md
docs/audit-log-filter-security.md
docs/audit-log-filter-variables.md
docs/filter-audit-log-filter-files.md
docs/index-contents.md
docs/index.md
docs/manage-audit-log-filter.md
docs/reading-audit-log-filter-files.md
docs/write-filter-definitions.md
mkdocs-base.yml