Skip to content

PER-10938: Drop harness skills from CodeRabbit guidelines - #2457

Merged
ninadbstack merged 1 commit into
masterfrom
PER-10938-drop-skills-from-coderabbit
Oct 9, 2026
Merged

ninadbstack merged 1 commit into
masterfrom
PER-10938-drop-skills-from-coderabbit

Conversation

@ninadbstack

@ninadbstack ninadbstack commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Why

Every CodeRabbit review here lists 4 entries under Skipped guideline sources:

invalid entry; expected repo:path or owner/repo:path with a relative file path

They are all harness skills. Skill paths look like skills/stack:<name>, and the second colon breaks CodeRabbit's owner/repo:path parsing. Skills are Claude Code workflows rather than review criteria, and the criteria they carried are already in the reviewer agents, so this config no longer lists them.

What changes

Regenerated .coderabbit.yaml with the updated generator from percy/browserstack-ai-harness-percy#2. The only change is that the 4 skill entries are removed. Rules, reviewer agents and applyTo scopes are unchanged.

Budget: 50 guideline files per review. 0 already tracked here and
auto-discovered (CLAUDE.md etc.), so 50 entries are available:
rules 12, reviewer agents 6, domain stack 32, conventions 0 — 29 lower-priority file(s) left out.

How to verify

This PR cannot test itself. CodeRabbit reviews config-changing PRs from non-collaborator authors with the target branch's config ("The proposed configuration will take effect after it is merged"), so the skipped skill entries in this PR's own review come from the current master config.

After merge, check the Review details on the next PR in this repo: there should be no Skipped guideline sources block, and Code guidelines should still list percy/browserstack-ai-harness-percy:stacks/... files.

Jira: PER-10938

🤖 Generated with Claude Code

Skill paths (skills/stack:<name>) carry a second colon, which CodeRabbit
rejects as an invalid owner/repo:path entry, so all 4 were listed under
"Skipped guideline sources" on every review. Regenerated from
percy/browserstack-ai-harness-percy#2, which stops listing skills.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ninadbstack
ninadbstack requested a review from a team as a code owner October 8, 2026 14:19
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited), Workspace UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Enterprise
  • Run ID: d7de5965-0976-44f9-8782-270e0e22ee39
📥 Commits

Reviewing files that changed from the base of the PR and between 80a7983 and b24979e.

📒 Files selected for processing (1)
  • .coderabbit.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: Build & verify executable
  • GitHub Check: Build
  • GitHub Check: Lint
  • GitHub Check: semgrep/ci
  • GitHub Check: Typecheck
  • GitHub Check: Build
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.coderabbit.yaml (1)

120-127: 🗄️ Data Integrity & Integration

The concern remains undecidable. The repository API and all four file requests returned 404 Not Found, but that response does not distinguish missing paths from inaccessible private-repository content. No CodeRabbit review output or installation-access result is available.


📝 Walkthrough

Walkthrough

The CodeRabbit configuration removes three skill references, adds four web-SDK snapshot-flow knowledge files, reorders the web-SDK CLAUDE.md entry, and updates the budget comment from 38 to 29 lower-priority files left out.

Changes

Guideline Configuration

Layer / File(s) Summary
Guideline entries and budget
.coderabbit.yaml
The configuration removes three skill entries, adds web-SDK knowledge entries for Playwright, Puppeteer, Selenium, and Storybook snapshot flows, moves the web-SDK CLAUDE.md entry earlier, and changes the budget comment from 38 to 29.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b2497

No confirmed merge-blocking issue is established; availability of the new guideline files can be checked once the updated configuration is active.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title contains the Jira ticket ID PER-10938 and a clear plain-English description. It accurately identifies the main change: removing harness skills from CodeRabbit guidelines.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ninadbstack
ninadbstack merged commit 289c2c0 into master Oct 9, 2026
50 of 51 checks passed
@ninadbstack
ninadbstack deleted the PER-10938-drop-skills-from-coderabbit branch October 9, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants