Add SSL verification options for P4 Code Review API requests#23
Open
benh57 wants to merge 1 commit intoperforce:mainfrom
Open
Add SSL verification options for P4 Code Review API requests#23benh57 wants to merge 1 commit intoperforce:mainfrom
benh57 wants to merge 1 commit intoperforce:mainfrom
Conversation
Add --ssl-no-verify and --ca-bundle CLI args, plus P4MCP_SSL_VERIFY and P4MCP_CA_BUNDLE environment variables, to control SSL certificate verification for P4 Code Review API connections. This enables use in environments with self-signed or internal CA certificates without requiring pip_system_certs (which does not work in PyInstaller-frozen builds). Priority order: CLI args > env vars > default (verify=True).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --ssl-no-verify and --ca-bundle CLI args, plus P4MCP_SSL_VERIFY and P4MCP_CA_BUNDLE environment variables, to control SSL certificate verification for P4 Code Review API connections.
This enables use in environments with self-signed or internal CA certificates without requiring pip_system_certs (which does not work in PyInstaller-frozen builds).
Priority order: CLI args > env vars > default (verify=True).