Open
Conversation
Add author[] and change query parameters to the list reviews action. - author[]: filter by review author(s), passed directly to the API - change: uses keywords + keywordsFields[]=changes (the change[] param was removed in Swarm API v10/v11; this is the correct v11 approach) - Added both params to the tool registration in server.py, the Pydantic model, the service layer, and the handler Also clarify the dashboard action description to indicate it returns reviews needing attention, not all authored/participated reviews.
benh57
force-pushed
the
feature/review-list-filters
branch
from
d24b90a to
59df1b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mcp had trouble finding a review when i asked it to find a review for a particular change (which wasn't on my dashboard due to being in 'needs review' state) -- it tried to find it on my dashboard instead and got confused. This adds a change filter to the reviews tool which helped it do that better. Note this is using the v11 api, which is different than v9 not sure if we need to support swarm api v9 or not.