Skip to content

pmrep.py: add units to CSV header output #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orasagar wants to merge 10 commits into
base: main
Choose a base branch
from
Open

pmrep.py: add units to CSV header output #2528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
88c2141
pmrep.py: add units to CSV header output
orasagar Mar 13, 2026
7e6f637
qa: update qa outputs for pmrep CSV unit labels
orasagar Mar 16, 2026
82c5e1c
pmrep: clarify CSV unit header row behavior
orasagar Mar 20, 2026
5174a22
qa/1929: add pmrep csv units header regression test
orasagar Mar 20, 2026
e555072
pmrep: cover pmrep no-units output in qa/1136
orasagar Mar 24, 2026
00ddb0a
pmrep: rename CSV to lower case csv
orasagar Mar 25, 2026
14d1153
pmrept: update csv headers with inline units
orasagar Mar 26, 2026
6a8ec23
pmrep: update pmrep csv unit header coverage
orasagar Apr 6, 2026
9ebb984
pmrep: --csv-unit-info option has been added and 1929 test case has b…
orasagar Apr 15, 2026
a3eb78e
1929: update pmrep csv unit header option and expected output
orasagar Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions qa/1136
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,24 @@ pmrep -z -a $tmp.archive.f -p -I -r -u $metrics
echo "=== pmrep csv output"
pmrep $log -o csv -p -I -r -u $metrics

echo "=== pmrep csv output (units via -U)"
pmrep $log -o csv -p -I -r -u -U $metrics

echo "=== pmrep csv output - filter"
pmrep $log -o csv -p -I -r -u -i '.*sdb.*' -i '.*sdd.*' $metrics

echo "=== pmrep csv output (no units)"
pmrep $log -o csv -p -I -r -u $metrics

echo "=== pmrep stdout output"
pmrep $log -o stdout -p -I -r -u $metrics

echo "=== pmrep stdout output - filter"
pmrep $log -o stdout -p -I -r -u -i '.*sdb.*' -i '.*sdd.*' $metrics

echo "=== pmrep stdout output (no units)"
pmrep $log -o stdout -p -I -r -u -U $metrics

echo "=== pmrep colxrow output"
pmrep $log -o stdout -p -I -r -u -X test $metrics

Expand Down
67 changes: 67 additions & 0 deletions qa/1136.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,28 @@ Time,"disk.dev.read-sda","disk.dev.read-sdb","disk.dev.read-sdc","disk.dev.read-
1970-01-01 00:00:17,,17,,,,,,,,,,
1970-01-01 00:00:18,,18,,,,,18,,,,,
1970-01-01 00:00:19,,19,,,,,19,,,,,
=== pmrep csv output (units via -U)
Time,"disk.dev.read-sda(count)","disk.dev.read-sdb(count)","disk.dev.read-sdc(count)","disk.dev.read-sdd(count)","disk.dev.read-sde(count)","disk.dev.write-sda(count)","disk.dev.write-sdb(count)","disk.dev.write-sdc(count)","disk.dev.write-sdd(count)","disk.dev.write-sde(count)","mem.util.free(Kbyte)","mem.util.used(Kbyte)"
1970-01-01 00:00:00,0,0,,,,0,0,,,,,
1970-01-01 00:00:01,1,1,,,,1,1,,,,,
1970-01-01 00:00:02,2,2,2,2,,2,2,2,2,,,2
1970-01-01 00:00:03,3,3,3,3,,3,3,3,3,,,3
1970-01-01 00:00:04,,4,,4,,,4,,4,,,4
1970-01-01 00:00:05,,5,,5,,,5,,5,,,5
1970-01-01 00:00:06,,6,,6,6,,6,,6,,,
1970-01-01 00:00:07,,7,,7,7,,7,,7,,,
1970-01-01 00:00:08,8,8,8,8,8,8,8,8,8,8,,8
1970-01-01 00:00:09,9,9,9,9,9,9,9,9,9,9,,9
1970-01-01 00:00:10,10,10,10,10,10,10,10,10,10,10,,10
1970-01-01 00:00:11,11,11,11,11,11,11,11,11,11,11,,11
1970-01-01 00:00:12,12,12,12,12,12,12,12,12,12,12,,12
1970-01-01 00:00:13,13,,13,,,13,,13,,,,13
1970-01-01 00:00:14,14,,14,,,14,,14,,,,14
1970-01-01 00:00:15,,,,,,,,,,,15,
1970-01-01 00:00:16,,,,,,,,,,,16,
1970-01-01 00:00:17,,17,,,,,,,,,,
1970-01-01 00:00:18,,18,,,,,18,,,,,
1970-01-01 00:00:19,,19,,,,,19,,,,,
=== pmrep csv output - filter
Time,"disk.dev.read-sdb","disk.dev.read-sdd","disk.dev.write-sdb","disk.dev.write-sdd","mem.util.free","mem.util.used"
1970-01-01 00:00:00,0,,0,,,
Expand All @@ -93,6 +115,28 @@ Time,"disk.dev.read-sdb","disk.dev.read-sdd","disk.dev.write-sdb","disk.dev.writ
1970-01-01 00:00:17,17,,,,,
1970-01-01 00:00:18,18,,18,,,
1970-01-01 00:00:19,19,,19,,,
=== pmrep csv output (no units)
Time,"disk.dev.read-sda","disk.dev.read-sdb","disk.dev.read-sdc","disk.dev.read-sdd","disk.dev.read-sde","disk.dev.write-sda","disk.dev.write-sdb","disk.dev.write-sdc","disk.dev.write-sdd","disk.dev.write-sde","mem.util.free","mem.util.used"
1970-01-01 00:00:00,0,0,,,,0,0,,,,,
1970-01-01 00:00:01,1,1,,,,1,1,,,,,
1970-01-01 00:00:02,2,2,2,2,,2,2,2,2,,,2
1970-01-01 00:00:03,3,3,3,3,,3,3,3,3,,,3
1970-01-01 00:00:04,,4,,4,,,4,,4,,,4
1970-01-01 00:00:05,,5,,5,,,5,,5,,,5
1970-01-01 00:00:06,,6,,6,6,,6,,6,,,
1970-01-01 00:00:07,,7,,7,7,,7,,7,,,
1970-01-01 00:00:08,8,8,8,8,8,8,8,8,8,8,,8
1970-01-01 00:00:09,9,9,9,9,9,9,9,9,9,9,,9
1970-01-01 00:00:10,10,10,10,10,10,10,10,10,10,10,,10
1970-01-01 00:00:11,11,11,11,11,11,11,11,11,11,11,,11
1970-01-01 00:00:12,12,12,12,12,12,12,12,12,12,12,,12
1970-01-01 00:00:13,13,,13,,,13,,13,,,,13
1970-01-01 00:00:14,14,,14,,,14,,14,,,,14
1970-01-01 00:00:15,,,,,,,,,,,15,
1970-01-01 00:00:16,,,,,,,,,,,16,
1970-01-01 00:00:17,,17,,,,,,,,,,
1970-01-01 00:00:18,,18,,,,,18,,,,,
1970-01-01 00:00:19,,19,,,,,19,,,,,
=== pmrep stdout output
d.d.read d.d.read d.d.read d.d.read d.d.read d.d.write d.d.write d.d.write d.d.write d.d.write m.u.free m.u.used
sda sdb sdc sdd sde sda sdb sdc sdd sde
Expand Down Expand Up @@ -141,6 +185,29 @@ Time,"disk.dev.read-sdb","disk.dev.read-sdd","disk.dev.write-sdb","disk.dev.writ
00:00:17 17 N/A N/A N/A N/A N/A
00:00:18 18 N/A 18 N/A N/A N/A
00:00:19 19 N/A 19 N/A N/A N/A
=== pmrep stdout output (no units)
d.d.read d.d.read d.d.read d.d.read d.d.read d.d.write d.d.write d.d.write d.d.write d.d.write m.u.free m.u.used
sda sdb sdc sdd sde sda sdb sdc sdd sde
00:00:00 0 0 N/A N/A N/A 0 0 N/A N/A N/A N/A N/A
00:00:01 1 1 N/A N/A N/A 1 1 N/A N/A N/A N/A N/A
00:00:02 2 2 2 2 N/A 2 2 2 2 N/A N/A 2
00:00:03 3 3 3 3 N/A 3 3 3 3 N/A N/A 3
00:00:04 N/A 4 N/A 4 N/A N/A 4 N/A 4 N/A N/A 4
00:00:05 N/A 5 N/A 5 N/A N/A 5 N/A 5 N/A N/A 5
00:00:06 N/A 6 N/A 6 6 N/A 6 N/A 6 N/A N/A N/A
00:00:07 N/A 7 N/A 7 7 N/A 7 N/A 7 N/A N/A N/A
00:00:08 8 8 8 8 8 8 8 8 8 8 N/A 8
00:00:09 9 9 9 9 9 9 9 9 9 9 N/A 9
00:00:10 10 10 10 10 10 10 10 10 10 10 N/A 10
00:00:11 11 11 11 11 11 11 11 11 11 11 N/A 11
00:00:12 12 12 12 12 12 12 12 12 12 12 N/A 12
00:00:13 13 N/A 13 N/A N/A 13 N/A 13 N/A N/A N/A 13
00:00:14 14 N/A 14 N/A N/A 14 N/A 14 N/A N/A N/A 14
00:00:15 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 15 N/A
00:00:16 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A 16 N/A
00:00:17 N/A 17 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
00:00:18 N/A 18 N/A N/A N/A N/A 18 N/A N/A N/A N/A N/A
00:00:19 N/A 19 N/A N/A N/A N/A 19 N/A N/A N/A N/A N/A
=== pmrep colxrow output
test d.d.read d.d.write m.u.free m.u.used
count count Kbyte Kbyte
Expand Down
8 changes: 8 additions & 0 deletions qa/1169
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,23 @@ pmrep $log -p -u -X test -1 -S @00:00:02 -s 2 -J 3 -e 'a = 100 * rate(disk.dev.r
echo "== csv test"
pmrep $log -p -u -o csv -1 disk.dev.read disk.dev.write mem.util.used | _archive_filter

echo "== csv test with units in header (-U)"
pmrep $log -p -u -o csv -1 -U disk.dev.read disk.dev.write mem.util.used | _archive_filter

echo "== csv test with extended header"
pmrep $log -p -u -o csv -1 -x -C disk.dev.read disk.dev.write mem.util.used | _archive_filter

echo "== csv test with repeating header"
pmrep $log -p -u -o csv -1 -E 3 disk.dev.read disk.dev.write mem.util.used | _archive_filter

echo "== csv test with repeating header with units (-U)"
pmrep $log -p -u -o csv -1 -E 3 -U disk.dev.read disk.dev.write mem.util.used | _archive_filter

echo "== csv test with extended/repeating header"
pmrep $log -p -u -o csv -1 -x -E 3 disk.dev.read disk.dev.write mem.util.used | _archive_filter

echo "== csv test with extended/repeating header with units (-U)"
pmrep $log -p -u -o csv -1 -x -E 3 disk.dev.read disk.dev.write mem.util.used -U | _archive_filter

echo "== fixed header test"
pmrep $log -p -u -X test -7 disk.dev.read disk.dev.write mem.util.used | _archive_filter
Expand Down
103 changes: 103 additions & 0 deletions qa/1169.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,36 @@ Time,"disk.dev.read-sdb"
1970-01-01 00:00:18,1.000
Time,"disk.dev.read-sdb","disk.dev.write-sdb"
1970-01-01 00:00:19,1.000,1.000
== csv test with units in header (-U)
1970-01-01 00:00:00
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)"
1970-01-01 00:00:01,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:02,1.000,1.000,1.000,1.000,2
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:03,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,3
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:04,1.000,1.000,1.000,1.000,4
1970-01-01 00:00:05,1.000,1.000,1.000,1.000,5
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)"
1970-01-01 00:00:06,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)"
1970-01-01 00:00:07,1.000,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:08,1.000,1.000,1.000,1.000,1.000,8
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","disk.dev.write-sde(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:09,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,9
1970-01-01 00:00:10,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,10
1970-01-01 00:00:11,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,11
1970-01-01 00:00:12,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,12
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdc(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdc(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:13,1.000,1.000,1.000,1.000,13
1970-01-01 00:00:14,1.000,1.000,1.000,1.000,14
1970-01-01 00:00:17
Time,"disk.dev.read-sdb(count/s)"
1970-01-01 00:00:18,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.write-sdb(count/s)"
1970-01-01 00:00:19,1.000,1.000
== csv test with extended header
#
# archive: QAPATH/archives/dyninsts
Expand Down Expand Up @@ -1008,6 +1038,37 @@ Time,"disk.dev.read-sdb"
1970-01-01 00:00:18,1.000
Time,"disk.dev.read-sdb","disk.dev.write-sdb"
1970-01-01 00:00:19,1.000,1.000
== csv test with repeating header with units (-U)
1970-01-01 00:00:00
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)"
1970-01-01 00:00:01,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:02,1.000,1.000,1.000,1.000,2
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:03,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,3
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:04,1.000,1.000,1.000,1.000,4
1970-01-01 00:00:05,1.000,1.000,1.000,1.000,5
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)"
1970-01-01 00:00:06,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)"
1970-01-01 00:00:07,1.000,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:08,1.000,1.000,1.000,1.000,1.000,8
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","disk.dev.write-sde(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:09,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,9
1970-01-01 00:00:10,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,10
1970-01-01 00:00:11,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,11
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","disk.dev.write-sde(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:12,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,12
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdc(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdc(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:13,1.000,1.000,1.000,1.000,13
1970-01-01 00:00:14,1.000,1.000,1.000,1.000,14
1970-01-01 00:00:17
Time,"disk.dev.read-sdb(count/s)"
1970-01-01 00:00:18,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.write-sdb(count/s)"
1970-01-01 00:00:19,1.000,1.000
== csv test with extended/repeating header
#
# archive: QAPATH/archives/dyninsts
Expand Down Expand Up @@ -1050,6 +1111,48 @@ Time,"disk.dev.read-sdb"
1970-01-01 00:00:18,1.000
Time,"disk.dev.read-sdb","disk.dev.write-sdb"
1970-01-01 00:00:19,1.000,1.000
== csv test with extended/repeating header with units (-U)
#
# archive: QAPATH/archives/dyninsts
# host: localhost
# timezone: UTC+0
# start: Thu Jan 1 00:00:00 1970
# end: Thu Jan 1 00:00:19 1970
# metrics: 3 (11 instances present in archive)
# samples: N/A
# interval: N/A
# duration: 00:00:19
#
1970-01-01 00:00:00
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)"
1970-01-01 00:00:01,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:02,1.000,1.000,1.000,1.000,2
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:03,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,3
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:04,1.000,1.000,1.000,1.000,4
1970-01-01 00:00:05,1.000,1.000,1.000,1.000,5
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)"
1970-01-01 00:00:06,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)"
1970-01-01 00:00:07,1.000,1.000,1.000,1.000,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdd(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:08,1.000,1.000,1.000,1.000,1.000,8
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","disk.dev.write-sde(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:09,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,9
1970-01-01 00:00:10,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,10
1970-01-01 00:00:11,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,11
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdb(count/s)","disk.dev.read-sdc(count/s)","disk.dev.read-sdd(count/s)","disk.dev.read-sde(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdb(count/s)","disk.dev.write-sdc(count/s)","disk.dev.write-sdd(count/s)","disk.dev.write-sde(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:12,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,1.000,12
Time,"disk.dev.read-sda(count/s)","disk.dev.read-sdc(count/s)","disk.dev.write-sda(count/s)","disk.dev.write-sdc(count/s)","mem.util.used(Kbyte)"
1970-01-01 00:00:13,1.000,1.000,1.000,1.000,13
1970-01-01 00:00:14,1.000,1.000,1.000,1.000,14
1970-01-01 00:00:17
Time,"disk.dev.read-sdb(count/s)"
1970-01-01 00:00:18,1.000
Time,"disk.dev.read-sdb(count/s)","disk.dev.write-sdb(count/s)"
1970-01-01 00:00:19,1.000,1.000
== fixed header test
test d.d.read d.d.write m.u.used
count/s count/s Kbyte
Expand Down
66 changes: 66 additions & 0 deletions qa/1929
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
#!/bin/sh
# PCP QA Test No. 1929
# csv output containing units tests with pmrep
#
# Copyright (c) 2026 Oracle and/or its affiliates.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#

seq=`basename $0`
echo "QA output created by $seq"

. ./common.python

$python -c "from pcp import pmapi" >/dev/null 2>&1
[ $? -eq 0 ] || _notrun "python pcp pmapi module not installed"
$python -c "from collections import OrderedDict" >/dev/null 2>&1
[ $? -eq 0 ] || _notrun "python collections OrderedDict module not installed"

which pmrep >/dev/null 2>&1 || _notrun "pmrep not installed"

status=1 # failure is the default!
trap "cd $here; _cleanup; exit \$status" 0 1 2 3 15

_cleanup()
{
rm -f $tmp.*
}

_msg_filter()
{
sed \
-e "s,Recording .* metrics.*,Recording metrics...,g" \
#end
}

_odd_filter()
{
sed \
-e '/00:00:06/s@N/A N/A N/A N/A@N/A 6 N/A 6@' \
# end
}

log="--archive $here/archives/dyninsts -z"
metrics="disk.dev.read disk.dev.write mem.util.free mem.util.used"

# real QA test starts here
echo "== csv header includes units row for archive"
pmrep $log -o archive -F $tmp.archive.a -p -I -r -u $metrics | _msg_filter
pmrep -z -a $tmp.archive.a -p -I -r -u $metrics \
| _odd_filter

echo "=== pmrep archive output - filter"
pmrep $log -o archive -F $tmp.archive.f -p -I -r -u -i '.*sdb.*' -i '.*sdd.*' $metrics | _msg_filter
pmrep -z -a $tmp.archive.f -p -I -r -u $metrics

echo "=== pmrep csv output with units header"
pmrep $log -o csv -p -I -r -u --csv-unit-info $metrics

echo "=== pmrep csv output - filter with units header"
pmrep $log -o csv -p -I -r -u -i '.*sdb.*' -i '.*sdd.*' --csv-unit-info $metrics

echo "=== pmrep csv output - filter without units header"
pmrep $log -o csv -p -I -r -u -i '.*sdb.*' -i '.*sdd.*' $metrics
# success, all done
status=0
exit
Loading
Loading