pmdasmart: Add nvme_error_log.total metric#2558
Merged
natoscott merged 1 commit intoperformancecopilot:mainfrom Apr 13, 2026
Merged
pmdasmart: Add nvme_error_log.total metric#2558natoscott merged 1 commit intoperformancecopilot:mainfrom
natoscott merged 1 commit intoperformancecopilot:mainfrom
Conversation
natoscott
reviewed
Apr 12, 2026
| if (found_nvme_log && strstr(buffer, "No Errors Logged")) | ||
| if (found_nvme_log && strstr(buffer, "No Errors Logged")) { | ||
| // No error entries head to next drive | ||
| dev->nvme_error_log_total = 0; |
Member
There was a problem hiding this comment.
The logic here is a bit questionable - when we break here, this zeroing of nvme_error_log_total may be overwritten unintentionally with 'count' outside the loop, no?
Collaborator
Author
There was a problem hiding this comment.
Indeed, the statement is redundant also as the value is initialised on line 1436. I will update the commit to fix this. Thanks
Add smart.nvme_error_log.total metric that reports the total number of NVMe error log entries per disk, returning zero when no errors exist. Available for both device name and WWID instances.
pauljevans
force-pushed
the
pevans-merge
branch
from
8fddb88 to
c37edbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add smart.nvme_error_log.total metric that reports the total number of NVMe error log entries per disk, returning zero when no errors exist. Available for both device name and WWID instances.