Skip to content

Feat/badge status variant#152

Merged
charlinemons merged 4 commits into
mainfrom
feat/badge-status-variant
Jun 17, 2026
Merged

Feat/badge status variant#152
charlinemons merged 4 commits into
mainfrom
feat/badge-status-variant

Conversation

@charlinemons

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: framework-ui.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@AssisrMatheus AssisrMatheus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlinemons

The names should be a bit more generic. Rather being "New", "discontinued". This is too specific for this use case and badges can be used for multiple things.

We can either name it with like:
variant one, variant two, variant three. Since each brand might want to have completely different variants, and each brand decides whatever they want with those "slots", and we alias them on the project itself

or something like what we usually do for buttons: primary, secondary, outline, faint, error, success, etc. (which I prefer, but might not work in this case for example, unless we find good names)

I would have claude suggest some naming that would work for this case!

It wouldn't make sense for another project, like the perimeter website, to have a "discontinued" badge, for example.

@AssisrMatheus AssisrMatheus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlinemons charlinemons merged commit 75e607b into main Jun 17, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants