Skip to content

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented May 27, 2025

Also moves CRC8 logic into common package for re-usability across multiple packages.

Move CRC8 logic into common package for resuability.
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 78.03468% with 38 lines in your changes missing coverage. Please review.

Project coverage is 52.9%. Comparing base (f009056) to head (8a85f99).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
sht4x/sht4x.go 78.3% 25 Missing and 8 partials ⚠️
hdc302x/hdc302x.go 37.5% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #109     +/-   ##
=======================================
+ Coverage   52.4%   52.9%   +0.5%     
=======================================
  Files        113     116      +3     
  Lines      14226   14617    +391     
=======================================
+ Hits        7455    7727    +272     
- Misses      6425    6526    +101     
- Partials     346     364     +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm not super enthusiast with the package name "common" but I don't have a good suggestion readily available so it's fine.

@maruel maruel merged commit 01409c1 into periph:main May 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants