Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/webpack.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: NodeJS with Webpack

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Build
run: |
npm install
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow uses npm install even though the repo has a package-lock.json. For CI builds, npm ci is deterministic and typically faster, and it matches existing CI usage in .github/workflows/test.yml:21-22. Consider switching to npm ci here as well to avoid lockfile drift and non-reproducible installs.

Suggested change
npm install
npm ci

Copilot uses AI. Check for mistakes.
npx webpack
Comment on lines +18 to +28
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

steps: is defined, but the list items below it are not indented under the steps key (the - uses: lines are aligned with steps:). This makes the YAML invalid and the workflow will fail to parse. Indent all step entries so the - items are nested under steps: (matching the indentation style used in .github/workflows/test.yml:12-27).

Suggested change
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Build
run: |
npm install
npx webpack
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Build
run: |
npm install
npx webpack

Copilot uses AI. Check for mistakes.
Comment on lines +25 to +28
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build step runs npx webpack, but this repository doesn't appear to include Webpack (no webpack dependency in package.json and no webpack config file found). As-is, the workflow will fail at runtime. Either add/configure Webpack as part of this PR, or change the workflow to run the project's existing build script (e.g., npm run build).

Copilot uses AI. Check for mistakes.
Loading