Repository navigation
fix: support LF line endings for @pest-mutate-ignore on Windows - #44
Open
webdevsamran wants to merge 1 commit into
Open
webdevsamran wants to merge 1 commit into
webdevsamran wants to merge 1 commit into
Conversation
…indows Signed-off-by: Samran Asif <samranwebdev2000@gmail.com>
This was referenced Sep 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pestphp/pest#1928
Problem
On Windows,
MutationGenerator::generate()parses@pest-mutate-ignoreannotations by splitting file contents onPHP_EOL:On Windows,
PHP_EOLevaluates to"\r\n". When inspecting source files that use UnixLF(\n) line endings (such as repositories witheol=lfin.gitattributes),explode()does not split the file. The entire file is treated as a single line, causing any ignore comment anywhere in the file to be attributed to line 1 ($lineNumber + 1 = 1). Consequently, mutants on their actual lines are not suppressed and fail mutation testing runs.Solution
Replace
explode(PHP_EOL, $contents)withpreg_split('/\R/', $contents)to handle all OS newline formats (\n,\r\n,\r) consistently across platforms.Verification
tests/Unit/MutationGeneratorTest.phpasserting that@pest-mutate-ignorecorrectly ignores mutators on lines beyond line 1 when files useLFline endings.