Add default failure messages to the remaining string expectations - #1948
Open
VincentBorgers wants to merge 1 commit into
Open
VincentBorgers wants to merge 1 commit into
VincentBorgers wants to merge 1 commit into
Conversation
VincentBorgers
force-pushed
the
default-failure-messages-string-expectations
branch
from
October 5, 2026 12:18
315bc30 to
39e2bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Thirteen string expectations fall back to PHPUnit's
Failed asserting that false is true.when they fail, while their siblings (toBeEmail,toBeUrl,toBeSlug, and the case expectations) already build a descriptive default message.This adds matching default messages to the remaining string expectations, so each one reports what it checked:
toBeDigits,toBeUppercase,toBeLowercase,toBeAlphaNumeric,toBeAlpha,toBeUuid,toBeUlid,toBeIpAddress,toBeMacAddress,toBeHostname,toBeDomain,toBeBase64, andtoBeHexadecimal.A custom message passed to the expectation still takes precedence. Each expectation's test gains a
failures with default messagecase, and the success snapshot is updated.