Repository navigation
fix: narrow file picker data fallback errors - #146
Merged
petercorke merged 4 commits intoOct 17, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
petercorke
approved these changes
Oct 17, 2026
Owner
|
Thanks — narrowing the fallback to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the data-directory fallback in #115's base/imageio.py group.
The file picker falls back to the home directory only for ModuleNotFoundError (missing data package) or ValueError (data path not found), matching the resolver's actual failure modes. Unexpected resolver failures now propagate instead of being silently hidden.
Five adapter tests cover the resolved data directory, both supported fallbacks, RuntimeError propagation and KeyboardInterrupt propagation. The RuntimeError regression fails on the original implementation.
Validation on Python 3.11:
Tests replace the tkinter dialog with an adapter; no real desktop file picker was opened. Full suite on OpenCV 4 was not run. Other #115 sites remain separate.