Repository navigation
fix: idisp() crashes when reuse=True with no title given - #94
Merged
Merged
Conversation
The OpenCV display path only auto-generated a window title when reuse=False -- `if not reuse and title is None: ...` -- so reuse=True with no explicit title left title as None, and the very next line's `assert title is not None` (added later, with a comment claiming this was already guaranteed) crashed with a bare AssertionError instead of ever reaching cv2.namedWindow(). reuse=True is meant for an animation loop redrawing into the same window across many calls, so the fallback can't be the existing counter-incremented "idisp.N" (that would open a new window per call, defeating reuse) -- use a fixed generic title instead, so repeated calls without an explicit title still share one window. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image.disp(reuse=True, matplotlib=False)with notitle=given crashes with a bareAssertionError, instead of opening/reusing a window.reuse=False(if not reuse and title is None: ...). Withreuse=Trueand no explicittitle,titlestaysNone, and the very next line'sassert title is not None(added later, with a comment claiming this was already guaranteed -- it wasn't, for this exact case) fails.reuse=Trueis meant for an animation loop redrawing into the same window across many calls, so the fallback can't be the existing counter-incremented"idisp.N"naming (that opens a new window per call, defeatingreuse). Uses a fixed generic title instead, so repeated calls without an explicit title still share one window.Test plan
tests/base/test_io.py::TestIdisp::test_idisp_reuse_no_title(new) -- two consecutivereuse=Truecalls with no title, must not raiseimage.disp(reuse=True, fps=20, matplotlib=False))🤖 Generated with Claude Code