fix: resolve tab close and a startup crash on macOS that occured#115
Merged
petertzy merged 1 commit intopetertzy:mainfrom Mar 9, 2026
Merged
fix: resolve tab close and a startup crash on macOS that occured#115petertzy merged 1 commit intopetertzy:mainfrom
petertzy merged 1 commit intopetertzy:mainfrom
Conversation
first trying to start the project via app.py - Fix tab body click triggering close by computing relative_x against the clicked tab's true left edge instead of the notebook origin (@ui.py line 727) - Fix app crash on startup by catching RuntimeError from tkinterdnd2 when the native tkdnd library fails to load on macOS (@app.py line 35)
jonaebel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first trying to start the project via app.py
fix Clicking on a tab (not the "X") should not close the tab #108 tab body click triggering close by computing relative_x against the clicked tab's true left edge instead of the notebook origin (@ui.py line 727)
Fix app crash on startup by catching RuntimeError from tkinterdnd2 when the native tkdnd library fails to load on macOS (@app.py line 35)