Haiku "build" fix by Begasus · Pull Request #55 · petitlapin/Li-Ri

Begasus · 2025-12-23T14:27:16Z

No description provided.

Begasus · 2025-12-23T14:29:25Z

This only fixes the build, launching it still errors out not finding the assets?

~> Li-ri 
screen frame: BRect(l:0.0, t:0.0, r:1919.0, b:1079.0)

OpenGL load add-on: /boot/system/add-ons/opengl/Software Pipe
OpenGL add-on registered: /boot/system/add-ons/opengl/Software Pipe
GalliumContext: CreateDisplay: Using llvmpipe (LLVM 12.0.1, 256 bits) driver.
screen frame: BRect(l:0.0, t:0.0, r:1919.0, b:1079.0)

ERROR: Unable to find 'Sounds/clic.wav'
ERROR: Unable to find 'Sounds/speed.wav'
ERROR: Unable to find 'Sounds/crash.wav'
ERROR: Unable to find 'Sounds/end.wav'
ERROR: Unable to find 'Sounds/lose.wav'
ERROR: Unable to find 'Sounds/etire.wav'
ERROR: Unable to find 'Sounds/wagon.wav'
ERROR: Unable to find 'Sounds/reduit.wav'
ERROR: Unable to find 'Sounds/live.wav'
ERROR: Unable to find 'Sounds/menu.mod'
ERROR: Unable to find 'language.dat'
ERROR: Unable to find 'language.dat'

petitlapin · 2025-12-23T15:06:23Z

This only fixes the build, launching it still errors out not finding the assets?

~> Li-ri 
screen frame: BRect(l:0.0, t:0.0, r:1919.0, b:1079.0)

OpenGL load add-on: /boot/system/add-ons/opengl/Software Pipe
OpenGL add-on registered: /boot/system/add-ons/opengl/Software Pipe
GalliumContext: CreateDisplay: Using llvmpipe (LLVM 12.0.1, 256 bits) driver.
screen frame: BRect(l:0.0, t:0.0, r:1919.0, b:1079.0)

ERROR: Unable to find 'Sounds/clic.wav'
ERROR: Unable to find 'Sounds/speed.wav'
ERROR: Unable to find 'Sounds/crash.wav'
ERROR: Unable to find 'Sounds/end.wav'
ERROR: Unable to find 'Sounds/lose.wav'
ERROR: Unable to find 'Sounds/etire.wav'
ERROR: Unable to find 'Sounds/wagon.wav'
ERROR: Unable to find 'Sounds/reduit.wav'
ERROR: Unable to find 'Sounds/live.wav'
ERROR: Unable to find 'Sounds/menu.mod'
ERROR: Unable to find 'language.dat'
ERROR: Unable to find 'language.dat'

Thanks! The data are supposed to be installed in ${CMAKE_INSTALL_DATADIR}/Li-ri (https://github.com/petitlapin/Li-Ri/blob/main/CMakeLists.txt#L111) and this can be configured in command-line invocation:

Li-Ri/INSTALL

Line 20 in 71195e6

    
           To specify the folder where to look for the data files, you can set the variable `LIRI_DATA_DIR` to the value you want in the cmake invocation: `cmake -DCMAKE_BUILD_TYPE=Release -S . -B build -DLIRI_DATA_DIR=/usr/local/Li-ri/data/`.

Begasus · 2025-12-23T15:09:33Z

Even with setting the data dir it doesn't seem to find them:

cmake -B build -S . -DCMAKE_INSTALL_PREFIX=/boot/home/config/non-packaged -DCMAKE_INSTALL_DATADIR=/boot/home/config/non-packaged/data/Li-ri

petitlapin · 2025-12-23T15:16:09Z

can you try: cmake -B build -S . -DCMAKE_INSTALL_PREFIX=/boot/home/config/non-packaged -DLIRI_DATA_DIR=/boot/home/config/non-packaged/data/Li-ri?

Begasus · 2025-12-23T15:19:00Z

can you try: cmake -B build -S . -DCMAKE_INSTALL_PREFIX=/boot/home/config/non-packaged -DLIRI_DATA_DIR=/boot/home/config/non-packaged/data/Li-ri?

Almost, this worked :)

cmake -B build -S . -DCMAKE_INSTALL_PREFIX=/boot/home/config/non-packaged -DLIRI_DATA_DIR=/boot/home/config/non-packaged/data/Li-ri -DCMAKE_INSTALL_DATADIR=/boot/home/config/non-packaged/data/

EDIT:

Only need to work this into a recipe update with this patch, will get back on that ;)

petitlapin · 2025-12-23T15:24:46Z

I can merge this PR and create a new release to make it easier

src/utils.cc

Begasus · 2025-12-23T15:26:17Z

Also used: (not sure if it's required)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 58d85f8..c5f0ca1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -91,9 +91,9 @@ target_link_libraries(${LIRI_EXECUTABLE_NAME} PRIVATE SimpleIni::SimpleIni)
 
 include(GNUInstallDirs)
 install(TARGETS ${LIRI_EXECUTABLE_NAME}
-  ARCHIVE DESTINATION bin
-  RUNTIME DESTINATION bin
-  LIBRARY DESTINATION lib
+  ARCHIVE DESTINATION ${CMAKE_INSTALL_BINDIR}
+  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
+  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
   BUNDLE DESTINATION .)
 
 install(FILES io.github.petitlapin.Li-ri.appdata.xml DESTINATION "${CMAKE_INSTALL_DATADIR}/appdata/")

EDIT: this sneaked in, in my work directory I don't have it :)

petitlapin · 2025-12-23T15:28:39Z

Also used: (not sure if it's required)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 58d85f8..c5f0ca1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -91,9 +91,9 @@ target_link_libraries(${LIRI_EXECUTABLE_NAME} PRIVATE SimpleIni::SimpleIni)
 
 include(GNUInstallDirs)
 install(TARGETS ${LIRI_EXECUTABLE_NAME}
-  ARCHIVE DESTINATION bin
-  RUNTIME DESTINATION bin
-  LIBRARY DESTINATION lib
+  ARCHIVE DESTINATION ${CMAKE_INSTALL_BINDIR}
+  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
+  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
   BUNDLE DESTINATION .)
 
 install(FILES io.github.petitlapin.Li-ri.appdata.xml DESTINATION "${CMAKE_INSTALL_DATADIR}/appdata/")

yes, let's make it cleaner (Probably need to add include(GNUInstallDirs)), thanks!

Begasus · 2025-12-23T16:24:55Z

yes, let's make it cleaner (Probably need to add include(GNUInstallDirs)), thanks!

Should I push that change also (PS GNUInstallDirs is already included)?
Another thing, I see it installs a header and cmake configuration files for SimpleIni, is that required?

src/utils.cc

petitlapin · 2025-12-23T16:34:34Z

yes, let's make it cleaner (Probably need to add include(GNUInstallDirs)), thanks!

Should I push that change also (PS GNUInstallDirs is already included)? Another thing, I see it installs a header and cmake configuration files for SimpleIni, is that required?

I've just pushed it directly.

For SimpleIni, can you run cmake with -DUSE_SYSTEM_SIMPLEINI=ON, to see if there no extra files (and in the recipe add it as dependency if you already have a recipe for it)? They should only be needed if we build it manually

Begasus · 2025-12-23T16:43:08Z

For SimpleIni, can you run cmake with -DUSE_SYSTEM_SIMPLEINI=ON, to see if there no extra files (and in the recipe add it as dependency if you already have a recipe for it)? They should only be needed if we build it manually

We don't have a seperate package for it it seems, another package pulls in the sources in the recipe (this way we can check the archive with a checksum which makes it safer to download then with using git). Going to check if I can do the same on our side.

EDIT: fixed local package for Simpleini :)
-- Found SimpleIni, version: 4.25

Begasus · 2025-12-23T18:41:01Z

OK, think I'm done here. If things get merged I'll hold of if you intend to release a new version. Thanks for the pointers!

petitlapin · 2025-12-23T19:16:15Z

OK, think I'm done here. If things get merged I'll hold of if you intend to release a new version. Thanks for the pointers!

thank you! Yes, I'm doing a release for it.

edit: tag v3.1.6 done :)

Begasus marked this pull request as draft December 23, 2025 15:01

Begasus force-pushed the haiku_build branch from da6b080 to 9f6165c Compare December 23, 2025 15:17

Begasus force-pushed the haiku_build branch from 9f6165c to 027b9e4 Compare December 23, 2025 15:25

petitlapin reviewed Dec 23, 2025

View reviewed changes

src/utils.cc Outdated Show resolved Hide resolved

Begasus force-pushed the haiku_build branch from 027b9e4 to e61a18e Compare December 23, 2025 16:22

petitlapin reviewed Dec 23, 2025

View reviewed changes

src/utils.cc Outdated Show resolved Hide resolved

Haiku "build" fix

ba7881a

Begasus force-pushed the haiku_build branch from e61a18e to ba7881a Compare December 23, 2025 17:03

Begasus marked this pull request as ready for review December 23, 2025 18:40

petitlapin merged commit 98200a0 into petitlapin:main Dec 23, 2025
7 checks passed

Conversation

Begasus commented Dec 23, 2025

Uh oh!

Begasus commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petitlapin commented Dec 23, 2025

Uh oh!

Begasus commented Dec 23, 2025

Uh oh!

petitlapin commented Dec 23, 2025

Uh oh!

Begasus commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petitlapin commented Dec 23, 2025

Uh oh!

Uh oh!

Begasus commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petitlapin commented Dec 23, 2025

Uh oh!

Begasus commented Dec 23, 2025

Uh oh!

Uh oh!

petitlapin commented Dec 23, 2025

Uh oh!

Begasus commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Begasus commented Dec 23, 2025

Uh oh!

petitlapin commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Begasus commented Dec 23, 2025 •

edited

Loading

Begasus commented Dec 23, 2025 •

edited

Loading

Begasus commented Dec 23, 2025 •

edited

Loading

Begasus commented Dec 23, 2025 •

edited

Loading

petitlapin commented Dec 23, 2025 •

edited

Loading