First draft of tests based on test-secret-handshake.#6
Draft
progval wants to merge 1 commit intopferreir:masterfrom
Draft
First draft of tests based on test-secret-handshake.#6progval wants to merge 1 commit intopferreir:masterfrom
progval wants to merge 1 commit intopferreir:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements GH-1 (using submodules instead of installing a package, but it's a detail)
There are still some missing parts, but I can't figure out how to use some of the test vectors.
Namely:
AttributeError: 'SHSClientCrypto' object has no attribute 'remote_ephemeral_key'; I'm probably not restoring the state properly, but can't find howThere are also a bunch of
FIXMEcomments.Exhaustive test results