Skip to content

Add a 'Back to login' link to the password pages (#9301)#10037

Open
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix-9301-back-to-login
Open

Add a 'Back to login' link to the password pages (#9301)#10037
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix-9301-back-to-login

Conversation

@dpage

@dpage dpage commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #9301.

The Forgot Password and Reset Password pages offered no way to navigate back to the login page. This adds a Back to login link to both pages, using the same login URL the login form already posts to.

Changes

  • ForgotPasswordPage.jsx / PasswordResetPage.jsx: render a "Back to login" link when a loginUrl is provided.
  • forgot_password.html / reset_password.html: pass loginUrl (url_for('authenticate.login')) in the page props.
  • Added release note (9.16).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added "Back to login" link on the forgot password and password reset pages for easier navigation back to authentication.
  • Documentation

    • Added release notes for pgAdmin 4 version 9.16, including new features and supported database versions.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@dpage, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 15ae3253-9061-4c8f-aab2-9c8fa3163064

📥 Commits

Reviewing files that changed from the base of the PR and between 8f03453 and 2e364e7.

📒 Files selected for processing (5)
  • docs/en_US/release_notes_9_16.rst
  • web/pgadmin/static/js/SecurityPages/ForgotPasswordPage.jsx
  • web/pgadmin/static/js/SecurityPages/PasswordResetPage.jsx
  • web/pgadmin/templates/security/forgot_password.html
  • web/pgadmin/templates/security/reset_password.html

Walkthrough

This PR implements issue #9301 by adding "Back to login" navigation links to the password recovery pages (Forgot Password and Password Reset). Users can now return to the login page without manually editing the URL. The feature is documented in v9.16 release notes and implemented across backend templates and React components.

Changes

Back to Login Navigation Feature

Layer / File(s) Summary
Release Notes Documentation for v9.16
docs/en_US/release_notes.rst, docs/en_US/release_notes_9_16.rst
Added v9.16 release notes with supported database server versions and new feature entry documenting the "Back to login" link (Issue #9301) on password recovery pages.
Templates: Passing loginUrl to Components
web/pgadmin/templates/security/forgot_password.html, web/pgadmin/templates/security/reset_password.html
Both templates extend page_props with loginUrl computed from url_for('authenticate.login'), providing the navigation URL to React components.
React Components: Rendering Back to Login Links
web/pgadmin/static/js/SecurityPages/ForgotPasswordPage.jsx, web/pgadmin/static/js/SecurityPages/PasswordResetPage.jsx
Both components accept loginUrl prop via destructuring, import MUI Box, and conditionally render a centered "Back to login" anchor link when loginUrl is present, with propTypes validation for the new prop.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding a 'Back to login' link to password pages, with the associated issue number.
Linked Issues check ✅ Passed All coding requirements from issue #9301 are met: 'Back to login' links added to ForgotPasswordPage and PasswordResetPage components with loginUrl prop, templates updated to pass loginUrl to page props.
Out of Scope Changes check ✅ Passed The addition of release notes for version 9.16 is a reasonable supplementary change related to documenting this feature, though slightly tangential to the core issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dpage dpage force-pushed the fix-9301-back-to-login branch 2 times, most recently from e6ad4c3 to 3d2b11a Compare June 9, 2026 11:36
The Forgot Password and Reset Password pages had no way to navigate back
to the login page. Added a "Back to login" link (using the login URL
already used by the login form) to both pages.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a user-visible navigation path back to the login page from the “Forgot Password” and “Reset Password” security pages, addressing #9301 and aligning with the existing login endpoint usage.

Changes:

  • Render a conditional Back to login link on Forgot/Reset password React pages when loginUrl is provided.
  • Pass loginUrl from the corresponding Jinja templates using url_for('authenticate.login').
  • Document the change in the v9.16 release notes.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/pgadmin/templates/security/reset_password.html Adds loginUrl to props passed into the reset password page.
web/pgadmin/templates/security/forgot_password.html Adds loginUrl to props passed into the forgot password page.
web/pgadmin/static/js/SecurityPages/PasswordResetPage.jsx Renders a centered “Back to login” anchor when loginUrl is present; updates propTypes.
web/pgadmin/static/js/SecurityPages/ForgotPasswordPage.jsx Renders a centered “Back to login” anchor when loginUrl is present; updates propTypes.
docs/en_US/release_notes_9_16.rst Adds a v9.16 release note entry for #9301.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option missiong on the reset password to navigate to another page

2 participants