Add a 'Back to login' link to the password pages (#9301)#10037
Conversation
|
Warning Review limit reached
More reviews will be available in 7 minutes and 27 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR implements issue ChangesBack to Login Navigation Feature
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e6ad4c3 to
3d2b11a
Compare
The Forgot Password and Reset Password pages had no way to navigate back to the login page. Added a "Back to login" link (using the login URL already used by the login form) to both pages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3d2b11a to
2e364e7
Compare
There was a problem hiding this comment.
Pull request overview
Adds a user-visible navigation path back to the login page from the “Forgot Password” and “Reset Password” security pages, addressing #9301 and aligning with the existing login endpoint usage.
Changes:
- Render a conditional Back to login link on Forgot/Reset password React pages when
loginUrlis provided. - Pass
loginUrlfrom the corresponding Jinja templates usingurl_for('authenticate.login'). - Document the change in the v9.16 release notes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/pgadmin/templates/security/reset_password.html | Adds loginUrl to props passed into the reset password page. |
| web/pgadmin/templates/security/forgot_password.html | Adds loginUrl to props passed into the forgot password page. |
| web/pgadmin/static/js/SecurityPages/PasswordResetPage.jsx | Renders a centered “Back to login” anchor when loginUrl is present; updates propTypes. |
| web/pgadmin/static/js/SecurityPages/ForgotPasswordPage.jsx | Renders a centered “Back to login” anchor when loginUrl is present; updates propTypes. |
| docs/en_US/release_notes_9_16.rst | Adds a v9.16 release note entry for #9301. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Fixes #9301.
The Forgot Password and Reset Password pages offered no way to navigate back to the login page. This adds a Back to login link to both pages, using the same login URL the login form already posts to.
Changes
ForgotPasswordPage.jsx/PasswordResetPage.jsx: render a "Back to login" link when aloginUrlis provided.forgot_password.html/reset_password.html: passloginUrl(url_for('authenticate.login')) in the page props.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation