Repository navigation
fix(toc): keep the fixed rail above the visible footer - #50
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7121e6a46e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| inset-block-start: var(--td-shell-nav-h); | ||
| inset-block-end: 0; | ||
| // Share the sidebar's available height when the footer enters view. | ||
| inset-block-end: var(--td-shell-footer-offset, 0px); |
There was a problem hiding this comment.
This changes the public fixed-rail behavior, but the commit contains only the implementation, checker, and tests; its own verification notes say the bilingual docsite companion is not represented as merged. That leaves the canonical consumer contract stale, so apply and land both language updates alongside this change.
AGENTS.md reference: AGENTS.md:L35-L37
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed: the canonical EN/ZH Design contract update has been added in pgsty/oink.pgsty.com#11, documenting the fixed TOC footer clearance, including pages without a left sidebar per AGENTS.md. I am leaving this thread open until that companion PR is merged.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ee2e78dcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 548e36d001
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56da1aaf41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| window.addEventListener('scroll', schedule, { passive: true }); | ||
| window.addEventListener('resize', schedule); | ||
| document.addEventListener('td:tab-shown', schedule); |
There was a problem hiding this comment.
The tab-specific listener resolves the earlier tab example, but fresh code evidence shows the same stale inset on blog indexes: with ui.blog_index_toggle enabled at xl and a fixed rail, the click path in docs-shell.js:1046-1068 swaps the differently sized list/cards/table layouts without emitting scroll, resize, or td:tab-shown. If that moves the footer into or out of view, the observer of only the footer's own size does not run, so --td-shell-footer-offset remains stale and the fixed rail is covered or truncated until the next scroll; route this form change through the scheduler or observe the article/layout.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed in Chromium: switching blog forms moves the footer without changing its size, so the current observer misses the change. Switching to cards can leave unnecessary bottom clearance; switching to the table can let the fixed rail overlap the footer. Observing the article height through the existing resize observer and scheduler should cover both cases. No fix has been committed yet, so this thread remains open.
2 participants
Fixes #49.
Problem
At the bottom of a desktop article, the native fat footer covers links in the fixed right rail. The rail still extends to the viewport bottom, so wheel scrolling may not reveal the final tag.
Change
--td-shell-footer-offsetfor the fixed rail's bottom inset.sidebar_enabled: false.The change reuses the existing scroll/resize handling and observer. Flow mode, no-footer fallback, mobile, and print behavior are preserved.
Validation
Previously completed native browser checks cover wheel scrolling, pointer/keyboard activation, optional left sidebar, and footer collapse/restore. In the comparison above, the rail ends above the footer and the final tag receives pointer hits. Full-site and cross-browser validation remain unverified.