ci: key the concurrency group on the pull request or branch - #3
Merged
Conversation
github.head_ref is only set on pull_request events. On push and workflow_dispatch it is empty, so every such run shared one group per workflow and cancel-in-progress made each cancel the last -- two pushes to main in quick succession, or a manual run alongside a push, could leave main with no completed CI. Key on the pull request number with a branch fallback, matching silo-console. Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.head_refis only set onpull_requestevents. Onpushandworkflow_dispatchit is empty, so every such run shared one group per workflow andcancel-in-progressmade each cancel the last — two pushes to main in quick succession, or a manual run alongside a push, could leave main with no completed CI.This was harmless while the fork's automatic triggers were off and every run was a manual dispatch. Now that push and pull_request triggers are enabled, it bites.
Key on the pull request number with a branch fallback, matching
silo-console's pattern.This PR doubles as a check that the newly enabled automatic triggers fire.