fix redundant MySQL display sizes and add tests#158
Open
elcreator wants to merge 1 commit intophalcon:masterfrom
Open
fix redundant MySQL display sizes and add tests#158elcreator wants to merge 1 commit intophalcon:masterfrom
elcreator wants to merge 1 commit intophalcon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
In MySQL8+ the numeric fields size (which is a display size 1-255 characters used in some clients and not the size of bytes used for a field) is redundant and so deprecated.