docs(manabrew-compat): correct the capability-registry counts - #6704
Merged
Conversation
The guide claimed 78 declared / 65 emitted. Four codes were added when the generic interaction path shipped (#6700) — simultaneous-decisions, schema-response, and aggregate-bound refusals, plus a narrowed prompt-unsupported — so the live figures are 82 and 69. The 13 documentary-only entries are unchanged, as is the invariant that matters: zero emitted codes are undeclared. Recomputed against this tree rather than carried over from the earlier count: declared 82 · emitted 69 · documentary-only 13 · undeclared emitted 0 which also agrees with the array's own type, `[UnsupportedCapability; 82]`.
matthewevans
enabled auto-merge
July 27, 2026 20:28
Contributor
📝 WalkthroughWalkthroughThe capability-registry documentation updates declared and emitted capability-code counts and explains that ChangesCapability registry documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/manabrew-compat/CLAUDE.md`:
- Line 60: Update the documentation around
no_emitted_capability_code_is_undeclared to avoid claiming manual audits are
unnecessary; describe only the guarantee the test actually enforces.
Alternatively, strengthen that test with exact assertions for the 69 emitted
codes, 82 registry entries, and 13 documentary-only entries, then retain the
claim only if those counts are enforced.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5949b8fb-9eb8-4ce8-b50a-6c6bde81c305
📒 Files selected for processing (1)
crates/manabrew-compat/CLAUDE.md
| Compare emitted codes against declared entries. Divergence is a defect, not a backlog item. | ||
|
|
||
| The registry is now **exhaustive** over emitted codes (78 declared; 65 emitted at live call sites, plus 13 documentary entries that describe a gap without a code path). `no_emitted_capability_code_is_undeclared` scans the production half of `lib.rs` and fails on any new undeclared code, so this no longer needs a manual audit — but re-run the command above if you doubt the test. | ||
| The registry is now **exhaustive** over emitted codes (82 declared; 69 emitted at live call sites, plus 13 documentary entries that describe a gap without a code path). `no_emitted_capability_code_is_undeclared` scans the production half of `lib.rs` and fails on any new undeclared code, so this no longer needs a manual audit — but re-run the command above if you doubt the test. |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Do not claim that manual auditing is no longer needed.
no_emitted_capability_code_is_undeclared only verifies that scanned emitted literals are declared; its distinct.len() >= 50 floor does not enforce 69 emitted codes, 82 registry entries, or 13 documentary-only entries. The documented counts can therefore drift while the test remains green. Either narrow this sentence to the guarantee actually enforced, or add exact count assertions in crates/manabrew-compat/src/lib.rs:8294-8357.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/manabrew-compat/CLAUDE.md` at line 60, Update the documentation around
no_emitted_capability_code_is_undeclared to avoid claiming manual audits are
unnecessary; describe only the guarantee the test actually enforces.
Alternatively, strengthen that test with exact assertions for the 69 emitted
codes, 82 registry entries, and 13 documentary-only entries, then retain the
claim only if those counts are enforced.
Source: Path instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide claimed 78 declared / 65 emitted. Four codes were added when the
generic interaction path shipped (#6700) — simultaneous-decisions,
schema-response, and aggregate-bound refusals, plus a narrowed
prompt-unsupported — so the live figures are 82 and 69. The 13 documentary-only
entries are unchanged, as is the invariant that matters: zero emitted codes are
undeclared.
Recomputed against this tree rather than carried over from the earlier count:
which also agrees with the array's own type,
[UnsupportedCapability; 82].Summary by CodeRabbit