ci: test on macOS and Windows, and actually run go test#308
Merged
nimish-ks merged 1 commit intoJul 6, 2026
Merged
Conversation
Contributor
Author
|
please review it and let me know if any changes needed |
nimish-ks
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expands the reusable test workflow (
.github/workflows/test.yml) to run onLinux, macOS, and Windows via an OS matrix, and adds a real
go test ./...step (the job was named "Go Test & Vet" but only ran
go vet+ a build check).Resolves #307
Why
ubuntu-latest, so platform-specific regressions (keyring, paths, terminalhandling) could ship unnoticed — see CLI is broken on windows git bash #80.
Changes
os: [ubuntu-latest, macos-latest, windows-latest]withfail-fast: false.go test ./...step.CGO_ENABLED=0to a job-levelenv:block (the inlineVAR=valueprefix is bash-only and breaks onWindows' default PowerShell), and replace
go build -o /dev/null ./withgo build ./...(/dev/nulldoesn't exist on Windows).Since
test.ymlis called by bothmain.ymlandrelease.yml, this coversPR CI and the release gate in one change.
Testing
go test ./...passes locally — 30 tests acrosscmd,pkg/ai,pkg/config,pkg/util.GOOS=windows go vet ./...andGOOS=windows go build ./...are clean.