fix: secret row hover menu positioning#939
Merged
Merged
Conversation
nimish-ks
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Overview
A small styling pass on the single-env secret row's hover action menus (the key/value field toolbars). Fixes a few rough edges: a sub-pixel gap between the menu and the input, the menu not blending correctly when a field is focused rather than hovered, inconsistent button sizing across breakpoints, and a long comment pushing the key menu wider than the key input.
💡 Proposed Changes
bottom-full) so they sit flush with the input's top edge regardless of text size — removes the 1–2px gap visible at smaller breakpoints.focus-within, but the background/corner blend and the focus ring only worked on hover. Matched the input background + squared the top-right corner on focus, and moved the focus ring onto the value textarea so it's actually visible.2xl, matching the value menu, and all buttons share a consistentpy-0.5 2xl:py-1rhythm.overflow-hiddenbackstop), so a long comment can no longer overflow the key column.buttonWrapperClassprop toGenericDialog(default no-op) so the comment trigger can shrink within the flex row.🖼️ Screenshots or Demo
Screencast.From.2026-07-01.19-02-42.mp4
📝 Release Notes
Polished the secret row hover menus: menus align flush with the field, blend correctly on focus, size consistently across breakpoints, and long comments no longer overflow the key column.
💚 Did You…
tsc --noEmitclean; dev server compiles clean