Tilemaps: findByIndex, putTilesAt and swapByIndex document parameters they do not take - #7350
Open
darkdi wants to merge 1 commit into
Open
Tilemaps: findByIndex, putTilesAt and swapByIndex document parameters they do not take#7350darkdi wants to merge 1 commit into
darkdi wants to merge 1 commit into
Conversation
…d setTilesets take
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)
Describe the changes below:
Was reading the Tilemaps source next to the generated typings and phaser.d.ts hands TypeScript users
swapByIndex(tileA, tileB, ...), while the method takesindexAandindexBand the sentence right above the tags already calls them that. Same drift infindByIndex,putTilesAtand the privatesetTilesets, inTilemap,TilemapLayerBaseand theFindByIndexcomponent. I lefttypes/alone since it is generated, so tsgen should pick these up on the next run.