Skip to content

fix: improve AI workflows, onboarding and LSP recovery - #3274

Open
abose wants to merge 16 commits into
mainfrom
ai
Open

abose wants to merge 16 commits into
mainfrom
ai

Conversation

@abose

@abose abose commented Oct 10, 2026 •

Copy link
Copy Markdown
Member
  • Make Surprise Me dismissible, clarify account options, and keep See a demo beside Sign In on small screens.
  • Update the Pro pin for demo playback that opens the generated page and the latest AI improvements.
  • Keep Live Preview choices selected until Send/Enter confirms, with Phoenix managing the reply and selection for built-in and custom cards.
  • Rotate the thinking status during long model responses while keeping the elapsed clock.
  • Fix valid multiline AI edits being rejected on Windows because of LF/CRLF differences, preserving file line endings and stale-content checks.
  • Expose Builder MCP settings in production when the diagnostic override is enabled.
  • Limit automatic PHP/Python setup and repair to once per day, with manual retry in Tasks and copyable failure details.
  • Raise the development build size limit from 105 MB to 110 MB to accommodate the current bundle.

Validation: full core lint passed; 48 choice/reminder checks passed on each native Windows, macOS and Linux runner. All 39 AI File Permissions checks passed on native Windows and macOS, and real Windows SDK edits preserved LF/CRLF formats. LSP setup checks passed on Linux browser and Windows (16 each), plus Windows PHP (7) and Python (8) integration checks. AI home and demo flows were reviewed in-app.

abose added 4 commits October 10, 2026 11:53
Replace the card's chevron area with a separate dismiss button and
divider. Keep the demo action independently clickable, and provide
hover, keyboard-focus and localized accessible-label support.

Verified the approved layout in the connected app. The full AI Chat CLI
integration suite passes 42 checks; LESS compilation and lint pass.
Describe the Claude subscription or API key option for Visual AI and
add localized subscription guidance for the default CLI cards.

Verified all three subtitles in the connected app. Changed-file lint
and whitespace checks pass.
Pin Phoenix Pro to dbc2888, including the reviewed light-theme fixes,
Surprise Me dismissal and subscription guidance from ee8ebb3, plus the
matching handoff note.

Validation: tracking JSON parses and the pin matches Pro HEAD. Dismissal
passed all 42 local AI Chat CLI checks; wording passed lint and connected
app review. Pipeline verification remains after push.
Replace subscription with account in the Visual AI and CLI descriptions,
while retaining the API key option for Visual AI.

Verified the localized strings and layout in the connected app.
Changed-file lint and whitespace checks pass.
@abose abose changed the title feat(ai): dismiss demo card and clarify subscription options feat(ai): dismiss demo card and clarify account options Oct 10, 2026
abose added 4 commits October 10, 2026 12:39
Place the demo and sign-in controls in equal-width columns and let the
sign-in illustration scroll when vertical space is limited. Label the
demo action See a demo with No sign-in needed as supporting text.

Verified compact layouts and all 26 native Linux recorder/demo tests.
LESS compilation, changed-file lint and whitespace checks pass.
Pin Phoenix Pro to aff5605 so demos open their generated pages in Live
Preview. Include the preceding account wording and sign-in action row.

Verified that the tracking JSON matches Pro HEAD. All 27 native Linux
recorder checks and the bundled/remote demo flows passed for this pin.
Register the Builder MCP dialog when production instrumentation is enabled at startup.
Show its diagnostics menu entry when the command is available and document the menu path.

Verified the menu, connection settings, console logs and production tab in Windows.
Confirmed disabled production builds keep the command hidden. Full core lint passed.
…emand

Persist one automatic PHP or Python setup attempt per day, including self-repair.
Keep manual installation available through a quiet Tasks entry after that limit.
Replace raw failure toasts with a failed task and a copyable error-details dialog.
Share in-flight installs so automatic repair cannot delete an active installation.

Verified all 16 LSP installation specs on Linux browser and native Windows runners.
Windows PHP and Python integration suites passed 7 and 8 specs respectively.
Full core lint passed. Reviewed the failure task and dialog in the connected app.
@abose abose changed the title feat(ai): dismiss demo card and clarify account options fix: improve AI onboarding and LSP setup recovery Oct 10, 2026
abose added 3 commits October 10, 2026 15:15
Normalize CRLF only when comparing edit text with captured file content.
Preserve raw snapshots, SDK inputs, file line endings and genuine stale-content checks.

Add four regressions to the registered AI File Permissions suite. All 39 specs
pass on native Windows and macOS. A real Windows SDK query also edited LF and
CRLF fixtures successfully while retaining their line endings.
Pin Phoenix Pro to the committed multiline edit findings and verification notes.
Confirm the tracking commit matches the Pro ai branch HEAD.
@abose abose changed the title fix: improve AI onboarding and LSP setup recovery fix: improve AI onboarding, Windows edits and LSP recovery Oct 10, 2026
abose added 3 commits October 10, 2026 17:17
Thirty general phrases the AI panel shows in turn while the model thinks
for a while, since the model reports no detail of what it is considering.
Pin Phoenix Pro to the commit that rotates the AI panel's thinking status
during long thinks.
Tell models that Phoenix owns selection and the reply composer confirms it.
Replace generated Pin and Choose handlers with declarative choice markers
and the select API, retaining reusable previews and cleanup guidance.

Advance the Pro pin to the matching implementation. All 42 choice and
6 reminder checks passed on each native Windows, macOS and Linux runner;
targeted ESLint and whitespace checks passed.

Also align the existing Node lockfile package metadata with version 5.5.5-0;
dependency versions and resolutions are unchanged.
@abose abose changed the title fix: improve AI onboarding, Windows edits and LSP recovery fix: improve AI workflows, onboarding and LSP recovery Oct 10, 2026
abose added 2 commits October 10, 2026 19:55
Open dropped paths sequentially so a slower earlier file cannot steal focus
from the last dropped file. Continue processing after individual failures
and retain the existing error reporting.

Cover a final image that is already open and a failed path followed by a
valid image in the existing LegacyInteg suite. All seven drag-and-drop
checks pass on native Windows, macOS and Linux.

Update the Pro pin to include the matching investigation and verification notes.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
15.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant