Skip to content

fix(ai): improve CLI handoff and sign-in, refresh Firefox CI - #3285

Merged
abose merged 5 commits into
mainfrom
ai
Oct 23, 2026
Merged

abose merged 5 commits into
mainfrom
ai

Conversation

@abose

@abose abose commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Ask AI could reject transfers to a connected Claude Code or Codex session because terminal
placeholder text and layout were mistaken for an occupied prompt. Update the unavailable-session
message and pin Phoenix Pro to d339871b86368b743624211d7d829edd91fd337f, which pastes the draft
directly into the selected live CLI and completes after the terminal write acknowledgement.
The user still reviews and submits the draft in the CLI; Phoenix does not send Enter.

The matching Pro update also routes expired Claude login notices through browser sign-in using
claude auth login. Update the button and hint to explain that flow. See
Pro #290 for the implementation.

Upgrade the locked Playwright version from 1.38.1 to 1.64.1, replacing Firefox 117 with Firefox
157 after hosted Windows runners began failing at browserContext.newPage before Phoenix
loaded. Enable Windows browser-process diagnostics for any remaining startup failures.
The macOS Firefox workflow and shared test ports are unchanged.

This branch is rebased onto core main at 489ddabae. The Pro pin matches the head of
Pro #290, rebased onto Pro main at fc81f87, so both include the merged layers-panel cleanup.

Validation:

  • CLI transfer: 49 CLI integration specs and 13 Live Preview Send specs pass on each of native
    Linux, Windows and macOS.
  • Expired-login flow: all 43 AI Chat CLI integration specs pass on native Linux and Windows;
    the Windows button also launches the browser login flow successfully.
  • Updated Playwright: all 2,891 Jasmine unit specs pass in each of Windows Firefox, Linux
    Firefox and Linux Chromium.
  • Core pre-commit ESLint, whitespace checks and active Firefox workflow syntax checks pass.
    Actionlint's existing checkout/setup-node v3 deprecation warnings are unchanged.
  • The published PR contains the four intended commits, and its Pro pin matches the published
    Pro PR head. Rebase comparisons confirm the existing feature patches were preserved.

Native and browser test results above were recorded before the rebase; no test suites were
rerun for the rebase. Native verification used development builds. Current hosted CI is running;
confirmation of the hosted Windows Firefox startup fix, packaged-release checks, and macOS
verification of the expired-login flow remain pending.

@abose abose changed the title fix(ai): ship direct CLI draft transfer with matching Pro pin fix(ai): improve CLI handoff and sign-in, refresh Firefox CI Oct 23, 2026
abose added 4 commits October 23, 2026 13:00
Update the unavailable-session message to ask for a running CLI instead of
claiming that the user must finish a question or approval. Ask AI now pastes
directly into the selected connected terminal without relying on its screen
layout, placeholder text, or echoed output.

Pin Phoenix Pro to 22122a7f72892dce39515ece8b17ac125d2d1263, which removes
the fragile prompt checks while retaining session validation, bracketed
paste without Enter, attachment snapshots, and failed-transfer recovery.
The Pro commit is rebased onto the updated local main branch.

Validation: 49 CLI integration specs and 13 Live Preview Send specs passed
in Linux Electron through the connected Jasmine runner. Targeted ESLint
and whitespace checks passed. A Windows release build and native platform
verification remain outstanding.
The expired-login button now opens the Claude sign-in page in the browser
instead of a terminal where the user had to type /login. Update its label
and hint to match.

Pin Phoenix Pro to 124c4b699b6f78d5bd5692e43482f29ca7853be0, which reuses
the first-use `claude auth login` flow for the expired-login button.

Validation: integration:AI Chat CLI 43/43 in Linux Electron.
Replace Playwright 1.38.1 and Firefox 117 with pinned Playwright 1.64.1 and Firefox 157
after hosted Windows runners began closing pages before Phoenix loaded. Include browser
process diagnostics in the Windows workflow for any remaining hosted-image failures.

Pin Pro to the completed CLI and browser verification records. Keep the macOS Firefox
workflow and shared test ports unchanged, as requested.

Validation: 2,891 Jasmine unit specs passed in each of Windows Firefox, Linux Firefox
and Linux Chromium. Active Firefox workflow syntax and whitespace checks pass.
Hosted Windows CI confirmation remains pending push.
Pin Phoenix Pro to its final local ai commit after rebasing both repositories
onto the latest origin/main. This includes the merged layers-panel cleanup
alongside the existing CLI paste and expired-login fixes.

Record the Pro tracking update for the completed rebases and cancellation
of the 14 obsolete workflow runs for merged core PR #3286.
@sonarqubecloud

Copy link
Copy Markdown

@abose
abose merged commit e8b4ca2 into main Oct 23, 2026
21 checks passed
@abose
abose deleted the ai branch October 23, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant