Add support for NIF version 2.18 (OTP 29)#103
Merged
Conversation
Owner
|
Awesome! Thank you, @Hermanverschooten! Later today I'm going to release a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for NIF version
2.18, which ships with Erlang/OTP 29.OTP 29's
erl_nif.hbumped the NIF interface to2.18(ERL_NIF_MAJOR_VERSION 2/ERL_NIF_MINOR_VERSION 18); OTP 26–28 remained on2.17. Without2.18in the available list, projects upgrading to a rustler that exposes thenif_version_2_18feature can't publish or select 2.18 precompiled artifacts.The forward-compatibility resolver (
find_compatible_nif_version/2) already handles running on a newer NIF than what's published, so no logic change was needed — only adding2.18to the allow-list.The default NIF version is unchanged (
2.15), so existing consumers are unaffected —2.18is opt-in vianif_versions:.