Base Implementation of Era Dynamis#31
Open
Frankie-hz wants to merge 27 commits intophoenixffxi:betafrom
Open
Conversation
Frankie-hz
force-pushed
the
eradyna
branch
8 times, most recently
from
18e2cd4 to
cbc294c
Compare
Frankie-hz
force-pushed
the
eradyna
branch
2 times, most recently
from
4edb0a5 to
66fbd3f
Compare
Frankie-hz
force-pushed
the
eradyna
branch
10 times, most recently
from
068c550 to
223b9db
Compare
Frankie-hz
force-pushed
the
eradyna
branch
7 times, most recently
from
d4886e5 to
2b7f2b6
Compare
Adds Dynamis Windurst Changes how aggro spawns work - forces the statues to spawn regardless of 1 shotting a statue
Frankie-hz
commented
Apr 14, 2026
Frankie-hz
commented
Apr 14, 2026
Comment on lines
+831
to
+865
| elseif mobType == 'Normal' then | ||
| m:addOverride(mobPath .. '.onMobSpawn', function(mob) | ||
| xi.dynamis.onMobSpawn(mob, mobType) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobRoam', function(mob) | ||
| xi.dynamis.onMobRoam(mob) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobDeath', function(mob, player, optParams) | ||
| xi.dynamis.onMobDeath(mob, player, optParams) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobDespawn', function(mob, player, optParams) | ||
| end) | ||
| elseif mobType == 'Nightmare' then | ||
| m:addOverride(mobPath .. '.onMobSpawn', function(mob) | ||
| xi.dynamis.onMobSpawn(mob, mobType) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobEngage', function(mob, target) | ||
| xi.dynamis.mobOnEngage(mob, target) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobRoam', function(mob) | ||
| xi.dynamis.onMobRoam(mob) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobDeath', function(mob, player, optParams) | ||
| xi.dynamis.onMobDeath(mob, player, optParams) | ||
| end) | ||
|
|
||
| m:addOverride(mobPath .. '.onMobDespawn', function(mob, player, optParams) | ||
| end) | ||
| end |
Author
There was a problem hiding this comment.
Can probably combine these two and add a check in engage for normal mobs to skip
Frankie-hz
force-pushed
the
eradyna
branch
2 times, most recently
from
1dfd923 to
d2c9d15
Compare
sruon
reviewed
Apr 15, 2026
| { | ||
| ['Dynamis-San_dOria'] = | ||
| { | ||
| { 'Overlords_Tombstone', 'Boss' }, |
There was a problem hiding this comment.
any reason for using 'Boss' or 'Normal' instead of an enum?
Author
There was a problem hiding this comment.
No particular reason, it was just the first way I thought of to separate different overrides. I can change it to an enum and condense the code below this as suggested.
Side note: I will need a way to override certain monsters when I get to the balance portion because some mobs mechanics are different from retail vs era. Most likely will just need a separate override for that, it's only a handful of NMs.
|
|
||
| -- Special case for SJ zones (7-9) | ||
| -- Dynamis - Buburimu (8), Dynamis - Qufim (9) | ||
| if zoneID == xi.zone.DYNAMIS_BUBURIMU or zoneID == xi.zone.DYNAMIS_QUFIM then |
Author
There was a problem hiding this comment.
There is no SJ NPC for Valkurm. It is handled on death of the 3 fly NMs
|
|
||
| m:addOverride(mobPath .. '.onMobDespawn', function(mob, player, optParams) | ||
| end) | ||
| elseif mobType == 'Nightmare' then |
There was a problem hiding this comment.
there's a lot of code repetition here, maybe you could have a single table such as:
{
[xi.dynamisType.STATUE] =
{
onMobEngage = xi.dynamis.onStatueEngage,
}
[...]
}
Then your code can just iterate on the list.
- Fixes unlimited TE multi lockout - Fixes an issue where the original registrant can bypass the entire lockout - Fixes infinite while loop is a mob for some reason couldnt spawn - Moves tav qm logic so it applies after the NPC is invis - increases capacity var correctly - Fixes issue where using the glass would constantly set the server var - Fixes rounding error of vanadiel days causing too fast of a lockout time - Fixes force spawn mobs to not spawn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR is the base implementation of Era Dynamis entry code, complete spawn mechanics and NPC interactions.
THIS DOES NOT INCLUDE ANY BALANCING
This PR includes all of the following zones.