fix(phx.gen.auth): delete old token when reissuing session#6657
Open
otlaitil wants to merge 1 commit intophoenixframework:mainfrom
Open
fix(phx.gen.auth): delete old token when reissuing session#6657otlaitil wants to merge 1 commit intophoenixframework:mainfrom
otlaitil wants to merge 1 commit intophoenixframework:mainfrom
Conversation
Fixes a bug where reissuing user session token leaves the old token to database. This bloats the database table and poses a minor security risk as old token will remain valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where reissuing user session token leaves the old token in the database. This bloats the database table and poses a minor security risk as old token will remain valid.
The fix copies the pattern from logout to clear the token
Steps to reproduce
mix phx.gen.auth Accounts User usersuser_auth.exset@session_reissue_age_in_days 0SELECT * FROM users_tokens;