refactor: add PHPStan generic type annotations and simplify detector implementations#563
Merged
Vitorinox merged 2 commits intophp-embed:masterfrom Oct 22, 2025
Merged
Conversation
…ctors
Added PHPDoc template annotations to improve type safety and PHPStan compatibility across all adapter classes. This change removes the need for inline @var annotations by properly declaring generic type
relationships between Extractors and Detectors.
Simplify code by directly accessing API from extractor property instead of using intermediate variable across multiple adapter detectors
Vitorinox
approved these changes
Oct 22, 2025
Collaborator
Vitorinox
left a comment
Vitorinox
left a comment
There was a problem hiding this comment.
Looks good! The added generics and refactors make the code cleaner and more maintainable without introducing any regressions. Approving this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sadly, PR #562 introduces some inline
@varUsing inline var is not encouraged.
https://phpstan.org/writing-php-code/phpdocs-basics#inline-%40var
Summary
This PR enhances type safety and code quality by adding PHPStan generic type annotations throughout the codebase and refactoring detector implementations to be more concise.
@extendsand@template-extendsgeneric type annotations to all Extractor and Detector classes across all adapters (Archive, Gist, ImageShack, Twitter, Wikipedia, Facebook, Github, Flickr, etc.)$extractorvariables in detector classes, accessing API directly via$this->extractor->getApi()createCustomDetectors()return type annotations by leveraging genericsBenefits