Fix grammar in language/types - #5746
Conversation
ba11f6c to
2063895
Compare
2063895 to
c14dfe5
Compare
jordikroon
left a comment
jordikroon
left a comment
There was a problem hiding this comment.
Some minor (non blocking) nits. Feel free to choose whatever you feel right with.
| <note> | ||
| <simpara> | ||
| On 32-bit builds, a <type>string</type> can be as large as up to 2GB | ||
| On 32-bit builds, a <type>string</type> can be as large as 2GB |
There was a problem hiding this comment.
How about this:
On 32-bit builds, a <type>string</type> can be up to 2GB (2147483647 bytes)..
| <simpara> | ||
| <type>mixed</type> is, in type theory parlance, the top type, | ||
| meaning every other type is a subtype of it. | ||
| </simpara> |
There was a problem hiding this comment.
While I agree with the changes. This phrase is that advanced that I don't believe the majority of the people that read the documentation will understand. Read: Non-native speakers.
My suggestion:
<type>mixed</type> is a special type that accepts values of any other type.
There was a problem hiding this comment.
That's already on the page a couple of lines above it. I agree, it's difficult to understand, but not sure that dumbing it down is a good idea. It says exactly what it was supposed to say for people who are interested in type theory. An average reader will stop on the first paragraph.
2 participants
The sentence in iterable.xml seems wrong or maybe I cannot understand it, but I don't know how to fix it.