RFC: Add Form Feed in Trim Functions#20788
Conversation
|
RFC (https://wiki.php.net/rfc/trim_form_feed) implemented, with specific test case. |
TimWolla
left a comment
There was a problem hiding this comment.
The default value specified in ext/standard/basic_functions.stub.php also needs to be adjusted.
TimWolla
left a comment
There was a problem hiding this comment.
The implementation itself LGTM now.
trim, rtrim and ltrim|
@LamentXU123 Thank you. Now merged. Don't forget to move your RFC into the “Implemented” section on the overview. Within the RFC document you should update the status as well and link to the implementation commit: da1e89f |
|
All done. Thank you. |
It is not necessary, the documentation team handles that based on the UPGRADING guide. But if you want, you can send a PR to https://github.com/php/doc-en/. |
I searched keyword
trimin the codebase and fix every case I think related to the three functions. I didn't touch other features with trim implemented and missing\f. (such astrimin php filters or other code)This PR changes:
charactersoftrim(alsoltrimandrtrim) in the php interface, adding\f, sourcephp_trim_int(which effectsphp_trim), source\f.I am sending mails to internals now. After that I will write the NEWS file (and docs) if this feature is accepted.
doc of trim: https://www.php.net/manual/en/function.trim.php
This is my first time contributing to php so I am not so sure about this PR. Thanks.
ps: also a little detail. I change the default parameter to
\f\n\t\r\v\0using alphabetic orders. (abcdefghijklmn...)RFC: https://wiki.php.net/rfc/trim_form_feed
Fixes GH-20783