zend_compile: Bundle function type constants into an zend_function_type enum#21208
Merged
TimWolla merged 5 commits intophp:masterfrom Feb 16, 2026
Merged
zend_compile: Bundle function type constants into an zend_function_type enum#21208TimWolla merged 5 commits intophp:masterfrom
zend_function_type enum#21208TimWolla merged 5 commits intophp:masterfrom
Conversation
ndossche
reviewed
Feb 13, 2026
…ype` enum This clarifies the relationship between these constants and improves type safety a little.
TimWolla
force-pushed
the
zend-function-type
branch
from
a6c8db0 to
2fcddda
Compare
ndossche
reviewed
Feb 13, 2026
iluuu1994
approved these changes
Feb 15, 2026
Girgias
approved these changes
Feb 15, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Looking forward to being able to use C23_ENUM more often! :)
ndossche
requested changes
Feb 15, 2026
arnaud-lb
approved these changes
Feb 16, 2026
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
Nice! There are some places where this would make the code clearer and help debuggers.
arnaud-lb
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clarifies the relationship between these constants and improves type safety a little.