ext/session: Fix implicit conversion warning#21216
Open
arshidkv12 wants to merge 3 commits intophp:masterfrom
Open
ext/session: Fix implicit conversion warning#21216arshidkv12 wants to merge 3 commits intophp:masterfrom
arshidkv12 wants to merge 3 commits intophp:masterfrom
Conversation
devnexen
reviewed
Feb 14, 2026
ext/session/mod_files.c
Outdated
Member
There was a problem hiding this comment.
if you change n type, it needs to reflect here
devnexen
reviewed
Feb 14, 2026
| ZVAL_NULL(retval); | ||
| } | ||
| PS(in_save_handler) = false; | ||
| for (i = 0; i < argc; i++) { |
Member
There was a problem hiding this comment.
then there is type mismatch with i
Contributor
Author
There was a problem hiding this comment.
I added these compiler flags, but no warnings are being shown.
CC = cc
CFLAGS = -Wconversion -O0
CFLAGS_CLEAN = $(CFLAGS) -D_GNU_SOURCE
CPP = cc -E
CPPFLAGS = -DHAVE_CONFIG_H
Member
There was a problem hiding this comment.
for sure. all I m saying is there is a signedness mismatch.
devnexen
reviewed
Feb 15, 2026
ext/session/mod_files.c
Outdated
|
|
||
| if (n != ZSTR_LEN(val)) { | ||
| if (n == (size_t)-1) { | ||
| if (n == (ssize_t)-1) { |
Member
There was a problem hiding this comment.
useless cast. ssize_t is signed.
Member
|
Let's give it a rest ... This kind of little changes, usually, deserve to be within larger refactoring but I ll leave it to @Girgias |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
-Wconversionwarning.