Skip to content

ext/sockets: socket_sendto() add max addr length control for AF_UNIX. #21217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devnexen wants to merge 1 commit into from
+35 −0
Closed

ext/sockets: socket_sendto() add max addr length control for AF_UNIX. #21217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext/sockets/sockets.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,6 +1584,12 @@ PHP_FUNCTION(socket_sendto)
switch (php_sock->type) {
case AF_UNIX:
memset(&s_un, 0, sizeof(s_un));

if (addr_len >= sizeof(s_un.sun_path)) {
zend_argument_value_error(5, "must be less than %d", sizeof(s_un.sun_path));
RETURN_THROWS();
}

s_un.sun_family = AF_UNIX;
snprintf(s_un.sun_path, sizeof(s_un.sun_path), "%s", addr);

Expand Down
29 changes: 29 additions & 0 deletions ext/sockets/tests/socket_sendto_unix_addr_too_long.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
--TEST--
socket_sendto() with AF_UNIX rejects address exceeding sun_path limit
--EXTENSIONS--
sockets
--SKIPIF--
<?php
if (substr(PHP_OS, 0, 3) == 'WIN') {
die('skip not valid for Windows');
}
?>
--FILE--
<?php
$socket = socket_create(AF_UNIX, SOCK_DGRAM, 0);
if (!$socket) {
die('Unable to create AF_UNIX socket');
}

$long_addr = str_repeat('a', 512);

try {
socket_sendto($socket, "data", 4, 0, $long_addr);
} catch (\ValueError $e) {
echo $e->getMessage() . PHP_EOL;
}

socket_close($socket);
?>
--EXPECTF--
socket_sendto(): Argument #5 ($address) must be less than %d
Loading