Fix PDOStatement::getIterator() not throwing when parameters are provided#21331
Closed
alexandre-daubois wants to merge 1 commit intophp:PHP-8.4from
Closed
Fix PDOStatement::getIterator() not throwing when parameters are provided#21331alexandre-daubois wants to merge 1 commit intophp:PHP-8.4from
alexandre-daubois wants to merge 1 commit intophp:PHP-8.4from
Conversation
Member
|
No, that macro will call zend_wrong_parameters_none_error so there is no bug here. |
Member
Author
|
Hmmm, then I'm not sure to get why most existing use of this macro are followed by |
Member
It's pointless, just convention. The only thing that macro does is assert an exception was thrown and then return. |
Member
Author
|
Got it, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDOStatement::getIterator()silently fails if arguments are provided, which is inconsistent with the rest of the file.