Skip to content

ext/pcntl: Bump num_signals to uint16_t #21347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NattyNarwhal wants to merge 1 commit into
base: PHP-8.5
Choose a base branch
from
+2 −1
Open

ext/pcntl: Bump num_signals to uint16_t #21347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ext/pcntl/php_pcntl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ ZEND_BEGIN_MODULE_GLOBALS(pcntl)
bool processing_signal_queue;
volatile bool pending_signals;
bool async_signals;
uint8_t num_signals;
/* some OSes define NSIG to be > UINT8_MAX */
uint16_t num_signals;
Copy link
Member

@iluuu1994 iluuu1994 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds padding before num_signals. Just to confirm: This is a private header, right?

Copy link
Member Author

@NattyNarwhal NattyNarwhal Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the only thing that references it is pcntl.c, yes. It shouldn't be installed either.

int last_error;
struct php_pcntl_pending_signal *head, *tail, *spares;
ZEND_END_MODULE_GLOBALS(pcntl)
Expand Down
Loading