Fix missing error propagation in openssl_x509_export_to_file()#21348
Open
ndossche wants to merge 2 commits intophp:PHP-8.4from
Open
Fix missing error propagation in openssl_x509_export_to_file()#21348ndossche wants to merge 2 commits intophp:PHP-8.4from
ndossche wants to merge 2 commits intophp:PHP-8.4from
Conversation
The file writes can have failed, but this error isn't visible for the application, fix it by propagating the error properly.
bukka
reviewed
Mar 5, 2026
ext/openssl/openssl.c
Outdated
| goto exit_cleanup_bio; | ||
| } | ||
|
|
||
| RETVAL_TRUE; |
Member
There was a problem hiding this comment.
Suggested change
| RETVAL_TRUE; | |
| if (!notext && !X509_print(bio_out, cert) && !PEM_write_bio_X509(bio_out, cert)) { | |
| php_openssl_store_errors(); | |
| } else { | |
| RETVAL_TRUE; | |
| } |
Something like this is probably better than goto...
Member
There was a problem hiding this comment.
ah sorry that applies notext, so maybe just some if / else if / else in that case
Member
Author
There was a problem hiding this comment.
Pushed a variant of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file writes can have failed, but this error isn't visible for the application, fix it by propagating the error properly.
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.