ext/intl: Reset IntlListFormatter error state in constructor - #22931
Merged
Conversation
Member
Author
|
@devnexen ping :) cuz I need this to be reviewed to continue my work about refactoring the error state. |
devnexen
approved these changes
Aug 1, 2026
LamentXU123
added a commit
that referenced
this pull request
Aug 1, 2026
* PHP-8.5: ext/intl: Reset IntlListFormatter error state in constructor (#22931)
LamentXU123
added a commit
that referenced
this pull request
Aug 2, 2026
Introduce PHP_INTL_FUNCTION_WITH_ERROR_RESET macro to standardize and automate the global Intl error state reset at the start of every userland PHP_FUNCTION. Also change the IC_METHOD function to automatically reset error state in the start of the defined function. The macro wraps the function entry point, performs intl_error_reset(NULL), and delegates the actual logic to a separate _impl function. This reduces boilerplate and prevents bugs caused by missing error resets, as seen in GH-22931 and GH-22500. This refactor applies to all functions with a manual reset call and does not affect internal helper functions that handle errors independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading the code base, I found the construct method in IntlListFormatter doesn't reset the error state.