Skip to content

[%pS migration] Use %pS in Zend/* - #23142

Open
DanielEScherzer wants to merge 24 commits into
php:masterfrom
DanielEScherzer:ps-migration-zend
Open

[%pS migration] Use %pS in Zend/*#23142
DanielEScherzer wants to merge 24 commits into
php:masterfrom
DanielEScherzer:ps-migration-zend

Conversation

@DanielEScherzer

Copy link
Copy Markdown
Member

No description provided.

@DanielEScherzer

DanielEScherzer commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

This is going to fix a bunch of null byte truncations that I haven't yet reported, basically every place a class entry name is accessed ZSTR_VAL was going to truncate anonymous class names
Is it worth creating a bug fix for the previous branches?

Also, on CircleCI it seems that the anonymous class names have different ending ($0 vs $1) - any ideas why? Edit: used %x instead

Looks like I also need to address the JIT versions of the errors Edit: done

In addition to the fixes within the zend_execute.c file, support for error
strings with null bytes was added to `zend_type_error()`.

Also update the ext/opcache helpers to match
@DanielEScherzer DanielEScherzer changed the title [%pS specifier migration] Use %pS in messages in Zend/* [%pS migration] Use %pS in Zend/* Aug 8, 2026
@DanielEScherzer
DanielEScherzer marked this pull request as ready for review August 8, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant