Skip to content

ext/curl: improved tests #23183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickSdot wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

ext/curl: improved tests #23183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ext/curl/tests/bug48207.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ foreach ([
] as $option) {
try {
curl_setopt($ch, $option, $fp);
} catch (ValueError $exception) {
echo $exception->getMessage(), "\n";
} catch (ValueError $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}
}

Expand All @@ -54,8 +54,8 @@ is_file($tempfile) and @unlink($tempfile);
isset($tempname) and is_file($tempname) and @unlink($tempname);
?>
--EXPECT--
curl_setopt(): The file handle provided for CURLOPT_FILE must be writable
curl_setopt(): The file handle provided for CURLOPT_WRITEHEADER must be writable
curl_setopt(): The file handle provided for CURLOPT_STDERR must be writable
ValueError: curl_setopt(): The file handle provided for CURLOPT_FILE must be writable
ValueError: curl_setopt(): The file handle provided for CURLOPT_WRITEHEADER must be writable
ValueError: curl_setopt(): The file handle provided for CURLOPT_STDERR must be writable
Hello World!
Hello World!
6 changes: 3 additions & 3 deletions ext/curl/tests/bug68089.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ $ch = curl_init();

try {
curl_setopt($ch, CURLOPT_URL, $url);
} catch (ValueError $exception) {
echo $exception->getMessage() . "\n";
} catch (ValueError $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

?>
Done
--EXPECT--
curl_setopt(): cURL option CURLOPT_URL must not contain any null bytes
ValueError: curl_setopt(): cURL option CURLOPT_URL must not contain any null bytes
Done
Loading