Make PDOStatement::setFetchMode() updates atomic - #23188
Open
iliaal wants to merge 1 commit into
Open
Conversation
pdo_stmt_setup_fetch_mode() cleared active fetch state before validating the replacement. Failed validation lost FETCH_INTO objects and FETCH_CLASS constructor arguments; autoload re-entry could also observe a mismatched tagged union. Validate the candidate entirely in local storage. Only after validation succeeds, replace the active payload and mode, and release the old payload from a coherent state. Closes phpGH-23188
iliaal
force-pushed
the
fix/pdo-setfetchmode-atomic
branch
from
August 9, 2026 14:33
54c43f7 to
d97dae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDOStatement::setFetchMode() discarded active FETCH_INTO or FETCH_CLASS state before validating its replacement. Validate the candidate in local storage, then replace the tagged-union payload and release the old state after a coherent commit. This preserves state on validation failure and makes autoload or destructor re-entry safe.