ext/uri: applied fixers to improve test robustness - #23271
Merged
Conversation
kocsismate
reviewed
Aug 14, 2026
kocsismate
approved these changes
Aug 14, 2026
kocsismate
left a comment
kocsismate
left a comment
Member
There was a problem hiding this comment.
LGTM especially if you change the catches to Throwable
NickSdot
force-pushed
the
hardening/ext-uri
branch
from
August 14, 2026 20:54
7b0a966 to
e8a6d4f
Compare
Member
|
thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one you didn't cherry pick (@ Tim); here without the style only lines. 🫡