ext/uri: Fixes fragment handler registration - #23303
Merged
Merged
Conversation
Member
|
Thanks for noticing this! I can confirm that the handler is not necessary, using the implementation alias is fine (and that was the intention, but I probably got confused. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #23286 the handler surfaced as uncovered. 18836 aliased, then 19636 added other aliases but also added the
getFragmenthandler back without removing its alias, which left it unused. In this PR:Timeline-wise it seems the intention was adding the handler back, but I don't see why -- so I am once again removing it here. If instead making the handler used is preferred, I can drop commit 2.