Fix parameter name in the convert_uudecode() warning - #23306
Open
lacatoire wants to merge 1 commit into
Open
Conversation
The warning names $data, but the parameter has been declared as $string since the stub was introduced, so following the message and calling convert_uudecode(data: ...) raises Error: Unknown named parameter $data. The message is a literal rather than a generated one, which is why it did not follow the parameter. Three tests pinning the old wording are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_uudecode()declares its parameter as$string, but its warning names$data:Following the message and calling
convert_uudecode(data: 'x')raisesError: Unknown named parameter $data, whilestring:works. Reproduced on 8.4.22 and 8.5.9.The message is a literal rather than a generated one, which is why it did not follow the parameter. This is the only place in the tree where a hardcoded
$datadoes not match the declared parameter; the other hits (bzcompress,bzdecompress,gmp_import,http_build_query) all belong to functions whose parameter really is named$data.Three tests pinned the old wording and are updated in the same commit.
Targeting master rather than a stable branch, since the warning text is observable output.