Skip to content

fix windows ci: w11 no longer treats names like NUL.txt as reserved #23844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bukka merged 1 commit into from
Sep 22, 2026
Merged

fix windows ci: w11 no longer treats names like NUL.txt as reserved #23844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions ext/standard/tests/file/ghsa-9f67-6fw4-hpfp-win32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,28 @@ foreach (['NUL', 'nul:', '\\\\.\\NUL'] as $name) {
}

echo "Reserved names in paths are rejected:\n";
foreach (['NUL', 'con', 'COM1', 'LPT9', 'CONIN$', 'NUL.txt', 'con.php', 'aux:stream', 'NUL .txt', 'NUL :txt', '.\\NUL'] as $name) {
foreach (['NUL', 'con', 'COM1', 'LPT9', 'CONIN$', '.\\NUL'] as $name) {
$blocked = $dir . DIRECTORY_SEPARATOR . $name;
var_dump(@fopen($blocked, 'wb') === false);
var_dump(file_exists($blocked));
}
var_dump(@fopen('NUL.txt', 'wb') === false);

echo "Suffixed device names:\n";
foreach (['NUL.txt', 'con.php', 'aux:stream', 'NUL .txt', 'NUL :txt'] as $name) {
$file = $dir . DIRECTORY_SEPARATOR . $name;
$h = @fopen($file, 'wb');
if (PHP_WINDOWS_VERSION_BUILD < 22000) {
var_dump($h === false);
} else {
// Windows 11 treats these as regular files
var_dump(is_resource($h) && (fstat($h)['mode'] & 0170000) === 0100000);
fclose($h);
// Delete the base file and its streams
$base = $dir . DIRECTORY_SEPARATOR . explode(':', $name)[0];
unlink('\\\\.\\' . $base . '::$DATA');
}
var_dump(file_exists($file));
}
var_dump(@stat($dir . DIRECTORY_SEPARATOR . 'NUL') === false);
var_dump(@mkdir($dir . DIRECTORY_SEPARATOR . 'NUL') === false);
var_dump(@rename(__FILE__, $dir . DIRECTORY_SEPARATOR . 'PRN') === false);
Expand Down Expand Up @@ -61,6 +77,7 @@ bool(true)
bool(false)
bool(true)
bool(false)
Suffixed device names:
bool(true)
bool(false)
bool(true)
Expand All @@ -75,7 +92,6 @@ bool(true)
bool(true)
bool(true)
bool(true)
bool(true)
Similar names are fine:
bool(true)
bool(true)
Expand Down
Loading