Add cgi.security_limit_extensions - #24010
Open
DanielEScherzer wants to merge 1 commit into
Open
DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
devnexen
reviewed
Sep 30, 2026
| * character after the extension, or the null terminating byte. */ | ||
| char *after = next + extension_len; | ||
| if ( | ||
| (next == allowed_extensions || (*(next - 1) == ' ') || (*(next - 1) == '\t')) |
Member
There was a problem hiding this comment.
nit: you can probably simplify all of this (e.g. str*spn)
Sjord
reviewed
Sep 30, 2026
Sjord
left a comment
Sjord
left a comment
Contributor
There was a problem hiding this comment.
Do you have some more context to this? Does this have an issue, RFC or mailing list thread? What is this supposed to accomplish exactly?
| } | ||
| /* }}} */ | ||
|
|
||
| zend_result cgi_limit_extensions(char *path) { |
Contributor
There was a problem hiding this comment.
Wouldn't it make more sense if this returned a bool directly? Returning SUCCESS or FAILURE does not make much sense here; the function does not fail, it just determined that it is a filtered extension.
| char *after = next + extension_len; | ||
| if ( | ||
| (next == allowed_extensions || (*(next - 1) == ' ') || (*(next - 1) == '\t')) | ||
| && (*after == '\0' || *after == ' ' || *after == '\t') |
Contributor
There was a problem hiding this comment.
It seems the extension list is whitespace separated, but I could also see people using comma's in it. Would it be helpful to handle comma's as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.